1592692 - Enable Resource blocking in all channels

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Let's enable resource blocking in all channels as soon as ready.

Honza

Comment 1

[Sebastian Zartner [:sebo]]

Please don't forget to set the dev-doc-needed flag for features which should be documented. Also, this sounds like something that should be in the release notes once it ships.

Sebastian

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1592692 - Enable Resource blocking in all channels

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The feature is stable according to manual QA testing.

Plan: Land in 72 and uplift to 71

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/599ede85d9d7
Enable Resource blocking in all channels r=Harald

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/599ede85d9d7

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9107464 [details]
Bug 1592692 - Enable Resource blocking in all channels

Beta/Release Uplift Approval Request

• User impact if declined: Developers not having the manual request blocking feature available by default
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature has been available in Nightly for testing, also available in DevEdition for testing and it went through QA
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9107464 [details]
Bug 1592692 - Enable Resource blocking in all channels

Enable on release/beta a devtools feature tested by QA, uplift approved for 71 beta 10, thanks.

Comment 8

[Narcis Beleuzu [:NarcisB]]

:honza, there is a conflict when grafting the changeset:

grafting 575710:599ede85d9d7 "Bug 1592692 - Enable Resource blocking in all channels r=Harald"
merging browser/app/profile/firefox.js
warning: conflicts while merging browser/app/profile/firefox.js! (edit, then use 'hg resolve --mark')

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0b52267741be

Comment 10

[Chris Mills [:cmills]]

Setting this to dev-doc-complete; since this got uplifted to 71, we dealt with it in the previous release cycle.

See

• https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor/request_list#Blocking_specific_URLs
• https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/71#Developer_tools

Let me know if there is anything else you think is needed here; thanks!