Closed Bug 1592808 Opened 11 months ago Closed 11 months ago

fullscreen tests in ContentDelegateTest need AssertCalled annotations

Categories

(GeckoView :: General, defect, P1)

Unspecified
All
defect

Tracking

(firefox71 wontfix, firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

(Whiteboard: [geckoview:m1910])

Attachments

(1 file)

The changes in bug 1583575 cause an additonal event (presumably a resize?) to call the ContentDelegate in the test cases, so the test proceeds without waiting specifically for onFullScreen to be called.

We should annotate these to ensure that we're waiting on the correct event for these test cases.

The changes in bug 1583575 cause an additonal event to call the ContentDelegate,
so the test proceeds without waiting specifically for onFullScreen to be called.

This patch annotates the onFullScreen overrides to ensure that we're waiting
on the correct event for these test cases.

Whiteboard: [geckoview:m1910]
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a98de0432770
Annotate ContentDelegate overrides for onFullScreen with AssertCalled; r=geckoview-reviewers,agi
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.