1592858 - Right-click "Inspect Accessibility Properties" doesn't scroll Accessibility view

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Chris Hall]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. Open the Wikipedia page for Firefox and move to the "History" section https://en.wikipedia.org/wiki/Firefox#History
2. Right click on the "History" title
3. Select "Inspect Element" from the right click menu
4. Notice that the Inspector panel opens and scrolls to the selected node
5. Again, Right click on the "History" title
6. Select "Inspect Accessibility Properties" from the right click menu
7. Notice that the accessibility inspector panel opens, but the accessibility node being inspected is often off the screen.

Platform details:
Freshly installed Firefox version 70.0 reporting build 20191016161957
Operating system is Mac OSX 10.14.6 (18G87)
Firefox troubleshooting information reports OS as "Darwin 18.7.0"

Actual results:

"Inspect Element" correctly scrolls to show the highlighted inspected item in view.
"Inspect Accessibility Properties" highlights the element, but does not scroll it into view, so it is often highlighting it off the screen.

Expected results:

"Inspect Accessibility Properties" should match the behavior of "Inspect Element" and scroll to have the inspected and highlighted accessibility node within view.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1592858 - scroll selected row in the tree view into view when inspecting an accessible object. r=mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/830dfd202450
scroll selected row in the tree view into view when inspecting an accessible object. r=mtigley

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/830dfd202450

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9115237 [details]
Bug 1592858 - scroll selected row in the tree view into view when inspecting an accessible object. r=mtigley

Beta/Release Uplift Approval Request

• User impact if declined: A most common workflow for inspecting the accessible object would look broken. The tree does not scroll into the right position and users get confused as to where they are in the accessibility tree view.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by tests, only affects specific inspect functionality in the accessibility tree developer tools.
• String changes made/needed: None

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9115237 [details]
Bug 1592858 - scroll selected row in the tree view into view when inspecting an accessible object. r=mtigley

devtools fix for 72.0b7

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bfcb666eaab9