Closed Bug 1592889 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 20013 - Don't look for property containers with multiple fragments.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 20013 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20013
Details from upstream follow.

Chris Harrelson <chrishtr@chromium.org> wrote:

Don't look for property containers with multiple fragments.

The MapToVisualRectInAncestorSpace fast-path needs a LayoutObject
with LocalBorderBoxProperties set, so that it can call into
GeometryMapper. If the start LayoutObject does not have one,
it proceeds up the containing block chain until it finds one, and
uses the FirstFragment() of the resulting LayoutObject. This is
wrong in cases where there multiple fragments on the LayoutObject,
because we don't know which one to choose. In such cases, fall back
to the slow path.

Bug: 999551

Change-Id: I887c15c3acbe41432b2ca64e5a1551f3765a5043

Reviewed-on: https://chromium-review.googlesource.com/1892058
WPT-Export-Revision: 0df365f91b96dad63e86f76eb62381a33d987d2a

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 1 subtests

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Gecko CI Results

Ran 1 tests and 1 subtests
OK : 1
PASS : 1

Automatic update from web-platform-tests
Don't look for property containers with multiple fragments.

The MapToVisualRectInAncestorSpace fast-path needs a LayoutObject
with LocalBorderBoxProperties set, so that it can call into
GeometryMapper. If the start LayoutObject does not have one,
it proceeds up the containing block chain until it finds one, and
uses the FirstFragment() of the resulting LayoutObject. This is
wrong in cases where there multiple fragments on the LayoutObject,
because we don't know which one to choose. In such cases, fall back
to the slow path.

Bug: 999551

Change-Id: I887c15c3acbe41432b2ca64e5a1551f3765a5043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892058
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711263}

--

wpt-commits: af0a7431ab977b1c169075a10fd44944b05079f9
wpt-pr: 20013

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6c88246bdac
[wpt PR 20013] - Don't look for property containers with multiple fragments., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.