Open Bug 1592975 Opened Last month Updated 15 days ago

2.99 - 8.02% raptor-tp6-instagram-firefox-cold / raptor-tp6-instagram-firefox-cold fcp / raptor-tp6-twitch-firefox fcp (linux64-shippable, linux64-shippable-qr) regression on push e66da643d9bcbc594a9c09a99271ae4d9415e388 (Wed October 30 2019)

Categories

(Core :: DOM: Security, defect, P1)

defect

Tracking

()

REOPENED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- wontfix
firefox72 --- affected

People

(Reporter: Bebe, Assigned: sstreich)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: perf, perf-alert, regression, Whiteboard: [domsecurity-active])

Attachments

(1 file)

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=e66da643d9bcbc594a9c09a99271ae4d9415e388

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

8% raptor-tp6-twitch-firefox fcp linux64-shippable opt 70.90 -> 76.58
5% raptor-tp6-instagram-firefox-cold fcp linux64-shippable-qr opt 188.96 -> 199.00
5% raptor-tp6-instagram-firefox-cold fcp linux64-shippable-qr opt 190.25 -> 198.83
3% raptor-tp6-instagram-firefox-cold linux64-shippable-qr opt 370.32 -> 381.40

Improvements:

26% raptor-tp6-twitch-firefox-cold fcp linux64-shippable-qr opt 115.46 -> 85.08
26% raptor-tp6-twitch-firefox-cold fcp linux64-shippable-qr opt 115.67 -> 85.42
9% raptor-tp6-twitch-firefox-cold linux64-shippable-qr opt 253.08 -> 231.46

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23640

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/TestEngineering/Performance/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/TestEngineering/Performance/Talos/RegressionBugsHandling

Blocks: 1592626
Component: Performance → DOM: Security
Flags: needinfo?(sstreich)
Product: Testing → Core
Regressed by: 1592651
Version: Version 3 → unspecified
Assignee: nobody → sstreich
Flags: needinfo?(sstreich)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebc3ca33bc0c
Re-enable XTCO per default r=ckerschb
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Is this wontfix for 71 given the regressing bug?

Flags: needinfo?(sstreich)

not sure this is the correct solution:
We just reverted the improvements in the last alert

== Change summary for alert #23736 (as of Thu, 07 Nov 2019 07:38:30 GMT) ==

Regressions:

39% raptor-tp6-twitch-firefox-cold fcp linux64-shippable-qr opt 89.92 -> 125.42
33% raptor-tp6-twitch-firefox-cold fcp linux64-shippable-qr opt 94.33 -> 125.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23736

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Basti, are you looking into this one?

Priority: -- → P1
Whiteboard: [domsecurity-active]

Hey, I'm a bit confused here. In the regressing patch we only disabled a pref.
In the patch provided here we re-enabled this, so we should be perfomance wise "pre regeression" right?

Flags: needinfo?(sstreich)

We have shipped our last beta for 71, so this is wontfix for 71.

You need to log in before you can comment on or make changes to this bug.