Closed Bug 1593001 Opened 5 years ago Closed 5 years ago

TypeError from MacTouchBar.js: BrowserWindowTracker.getTopWindow(...) is null, TouchBarHelper.window is null

Categories

(Firefox :: General, defect)

Unspecified
macOS
defect
Not set
normal
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- verified
firefox72 --- verified

People

(Reporter: Gijs, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. open browser on macOS with touchbar
  2. open browser toolbox

Alt STR:

  1. open browser on macOS with touchbar
  2. close window without closing browser

I dunno how catastrophic this is/isn't, but we should fix it.

I changed the way the TouchBarHelper class fetches the window in bug 1563349 Part 1, but didn't add enough null-checks to account for the new behaviour. Touch Bar code can fire when the window is closed, or when non-main windows are open (Library, browser toolbox) and that was causing this error. It's nothing serious, but I agree we should fix it. Patch incoming.

Regressed by: 1563349
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 72.2 - Nov 4 - 17
Points: --- → 2
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2ba246a4e9b
Add more stringent Touch Bar null-checks. r=mikedeboer
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Is this something we should consider uplifting to Beta or can this ride Fx72 to release?

Flags: needinfo?(htwyford)

I'd like to let it bake on Nightly for a few more days, but it could be uplifted if there are no new issues. The error that this bug fixes isn't serious, so it's not a huge deal if this ends up not being uplifted. Basically the error amounts to just printing a couple of lines of junk on window-close on some Macs.

I'm leaving needinfo so I remember to come back to this in a few days and request uplift if there are no issues.

Comment on attachment 9106237 [details]
Bug 1593001 - Add more stringent Touch Bar null-checks. r?mikedeboer

Beta/Release Uplift Approval Request

  • User impact if declined: Annoying errors printed in the console.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open Firefox on macOS attached to the terminal.
  1. Close the main window.
  2. If the error in the bug description is not printed in the terminal, the bug is fixed.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch adds some null-checks to the Touch Bar code to better handle window closes. Worst-case is that some Touch Bar functionality does not fire in edge cases (such as right before window close). No such loss of functionality has been reported on Nightly, and the Touch Bar is not a heavily used feature.
  • String changes made/needed:
Flags: needinfo?(htwyford)
Attachment #9106237 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9106237 [details]
Bug 1593001 - Add more stringent Touch Bar null-checks. r?mikedeboer

Low risk macos fix for errors logged by the touchbar, uplift approved for 71 beta 9, thanks.

Attachment #9106237 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Confirmed issue with 72.0a1(2019-10-31) on macOS 10.15.
Fix verified with :csasca on 72.0a1(2019-11-12) and 71.0b9 on Ubuntu 18.04 and macOS 10.15.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
OS: Unspecified → macOS
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: