Closed Bug 1593015 Opened 6 years ago Closed 6 years ago

Fix WebAssembly baseline codegen for if/then/else with parameters

Categories

(Core :: JavaScript: WebAssembly, defect, P3)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(1 file)

Bug 1593015 - Fix WebAssembly baseline codegen for if/then/else with parameters
47 bytes, text/x-phabricator-request
Details | Review

Test case (to be committed):

  (module
    (func (export "run") (result i32)
      (i32.const 32)
      (i32.const 10)
      (i32.const 1)
      (if (param i32 i32) (result i32)
          (then (i32.add))
          (else (i32.sub)))))

Basically there were some invariants of internal BaseCompiler APIs that we weren't quite respecting, which manifested as not being able to allocate the registers we needed.

Priority: -- → P3
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5bfb9d257c44 Fix WebAssembly baseline codegen for if/then/else with parameters r=lth

https://hg.mozilla.org/mozilla-central/rev/5bfb9d257c44

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: