Closed Bug 1593051 Opened Last month Closed Last month

Remove the "Ensure the XBL binding is created eagerly." code/comment in browser/components/preferences/applicationManager.js

Categories

(Firefox :: Preferences, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: bgrins, Assigned: christoph-wa)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/1fe0cf575841dbf3b7e159e88ba03260cd1354c0/browser/components/preferences/applicationManager.js#42-54

I expect that this line:

list.appendChild(MozXULElement.parseXULToFragment("<richlistitem/>"));
var item = list.lastChild;

Can be replaced with something like:

let item = document.createElement("richlistitem");
list.append(item);

Or for better performance: append all the items into a DocumentFragment in the loop, then append the DocumentFragment to the list after it's iterated.

Assignee: nobody → christoph-wa
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a44bfb190d80
Remove usage of parseXULToFragment from applicationManager.js r=bgrins
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.