1593051 - Remove the "Ensure the XBL binding is created eagerly." code/comment in browser/components/preferences/applicationManager.js

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[Brian Grinstead [:bgrins]]

https://searchfox.org/mozilla-central/rev/1fe0cf575841dbf3b7e159e88ba03260cd1354c0/browser/components/preferences/applicationManager.js#42-54

I expect that this line:

list.appendChild(MozXULElement.parseXULToFragment("<richlistitem/>"));
var item = list.lastChild;

Can be replaced with something like:

let item = document.createElement("richlistitem");
list.append(item);

Or for better performance: append all the items into a DocumentFragment in the loop, then append the DocumentFragment to the list after it's iterated.

Comment 1

[Christoph Walcher]

Attachment: Bug 1593051 - Remove usage of parseXULToFragment from applicationManager.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a44bfb190d80
Remove usage of parseXULToFragment from applicationManager.js r=bgrins

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a44bfb190d80