1593105 - [mozbuild] Port mozbuild.util.FileAvoidWrite to Python 3

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Māris Fogels [:mars] (please needinfo)]

mozbuild.util.FileAvoidWrite is a file-like object that buffers output and only writes if content changed. It breaks under Python 3 because it moves between bytes and str in a few places.

Test: ./mach python-test --python 3 --subsuite mozbuild test_util.py -k TestFileAvoidWrite

Comment 1

[Māris Fogels [:mars] (please needinfo)]

Attachment: Bug 1593105 - [mozbuild] Port mozbuild.util.FileAvoidWrite to Python 3 r=#build

The FileAvoidWrite class does a bunch of stuff with bytes and strings
that doesn't work in Python 3. Make sure the object is handling only
bytes or only strings under the hood so Python 3 is happy.

The FileAvoidWrite unit tests written with MockedOpen don't work in
Python 3 either. Swap them out for vanilla pytest tests without
the MockedOpen dependency.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a668eeee9830
[mozbuild] Port mozbuild.util.FileAvoidWrite to Python 3 r=firefox-build-system-reviewers,mshal

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a668eeee9830