1593135 - src/gfx/skia/skia/src/core/SkGeometry.cpp:379: fatal error: "assert(t > 0 && t < 1.0f)"

Status: RESOLVED WORKSFORME

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Reduced with m-c:
BuildID=20191031194708
SourceStamp=4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932

src/gfx/skia/skia/src/core/SkGeometry.cpp:379: fatal error: "assert(t > 0 && t < 1.0f)"

0|0|libxul.so|SkChopCubicAt(SkPoint const*, SkPoint*, float)|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkGeometry.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|394|0x0
0|1|libxul.so|SkContourMeasure_segTo(SkPoint const*, unsigned int, float, float, SkPath*)|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkContourMeasure.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|114|0x20
0|2|libxul.so|SkContourMeasure::getSegment(float, float, SkPath*, bool) const|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkContourMeasure.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|647|0x31
0|3|libxul.so|SkDashPath::InternalFilter(SkPath*, SkPath const&, SkStrokeRec*, SkRect const*, float const*, int, float, int, float, SkDashPath::StrokeRecApplication)|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/utils/SkDashPath.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|400|0x1c
0|4|libxul.so|SkDashImpl::onFilterPath(SkPath*, SkPath const&, SkStrokeRec*, SkRect const*) const|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/effects/SkDashPathEffect.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|45|0x22
0|5|libxul.so|SkPathEffect::filterPath(SkPath*, SkPath const&, SkStrokeRec*, SkRect const*) const|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkPathEffect.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|21|0x11
0|6|libxul.so|SkPaint::getFillPath(SkPath const&, SkPath*, SkRect const*, float) const|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkPaint.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|455|0x1b
0|7|libxul.so|SkDraw::drawPath(SkPath const&, SkPaint const&, SkMatrix const*, bool, bool, SkBlitter*) const|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkDraw.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|958|0x15
0|8|libxul.so|SkBitmapDevice::drawPath(SkPath const&, SkPaint const&, bool)|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkBitmapDevice.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|401|0x1c
0|9|libxul.so|SkCanvas::onDrawPath(SkPath const&, SkPaint const&)|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkCanvas.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|2365|0x25
0|10|libxul.so|SkCanvas::drawPath(SkPath const&, SkPaint const&)|hg:hg.mozilla.org/mozilla-central:gfx/skia/skia/src/core/SkCanvas.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1878|0x13
0|11|libxul.so|mozilla::gfx::DrawTargetSkia::Stroke(mozilla::gfx::Path const*, mozilla::gfx::Pattern const&, mozilla::gfx::StrokeOptions const&, mozilla::gfx::DrawOptions const&)|hg:hg.mozilla.org/mozilla-central:gfx/2d/DrawTargetSkia.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|784|0xf
0|12|libxul.so|mozilla::dom::CanvasRenderingContext2D::Stroke()|hg:hg.mozilla.org/mozilla-central:dom/canvas/CanvasRenderingContext2D.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|2788|0x21
0|13|libxul.so|mozilla::dom::CanvasRenderingContext2D_Binding::stroke|s3:gecko-generated-sources:26d2883906c71650a479569d8c5e8563ce2829976138a9116e8176d225c7fd262fa8f8e62bd5716a2a71d720c1523c40b43d8a640aa250e1b2a2b99b41406da2/dom/bindings/CanvasRenderingContext2DBinding.cpp:|2917|0x8
0|14|libxul.so|bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)|hg:hg.mozilla.org/mozilla-central:dom/bindings/BindingUtils.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|3218|0x24
0|15|libxul.so|CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|456|0x15
0|16|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|548|0x15
0|17|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|617|0x10
0|18|libxul.so|Interpret|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|3110|0x13
0|19|libxul.so|js::RunScript(JSContext*, js::RunState&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|423|0xb
0|20|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|589|0x13
0|21|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|617|0x10
0|22|libxul.so|js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|634|0x8
0|23|libxul.so|JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/jsapi.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|2702|0x1f
0|24|libxul.so|mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&)|s3:gecko-generated-sources:9ca8646d8042e9b4b76d2e1b358b984be17743b71b832c0897d61bb500e0fecbe38fa54273dc522878c87fcb2c9bfd274a8190c7bc56fbbb58cb3ca68462e527/dom/bindings/EventListenerBinding.cpp:|52|0x5
0|25|libxul.so|mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*)|s3:gecko-generated-sources:f3d9c01258576daaac3afc4fb3b283652e7f1168abb5287eff6775451ebd0ab6a0e4c8d88d3a67f7147042501bc091c6dfed25b4b8ccf4e4f420897b8d0ba906/dist/include/mozilla/dom/EventListenerBinding.h:|66|0x1c
0|26|libxul.so|mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool)|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1231|0x19
0|27|libxul.so|mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|351|0x6
0|28|libxul.so|mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|551|0x12
0|29|libxul.so|mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1050|0x1a
0|30|libxul.so|mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1150|0x19
0|31|libxul.so|nsINode::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1064|0x5
0|32|libxul.so|nsContentUtils::DispatchEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, mozilla::Trusted, bool*, mozilla::ChromeOnlyDispatch)|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|3991|0x30
0|33|libxul.so|nsContentUtils::DispatchTrustedEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, bool*)|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|3962|0x19
0|34|libxul.so|mozilla::dom::Document::DispatchContentLoadedEvents()|hg:hg.mozilla.org/mozilla-central:dom/base/Document.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|7068|0x40
0|35|libxul.so|mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1176|0x13
0|36|libxul.so|mozilla::SchedulerGroup::Runnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|295|0x15
0|37|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|1225|0x15
0|38|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|486|0x11
0|39|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|88|0xa
0|40|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|315|0x17
0|41|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|290|0x8
0|42|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|137|0xd
0|43|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|934|0x11
0|44|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|238|0x5
0|45|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|315|0x17
0|46|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|290|0x8
0|47|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|769|0xc
0|48|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|56|0x14
0|49|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:4a19c3f74d0cf11a6a2dc143b3b43a88a96f0932|272|0x12
0|50|libc-2.23.so|__libc_start_main|/build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c|291|0x1a
0|51|firefox-bin|_start|||0x29

Comment 1

[Lee Salzman [:lsalzman]]

I thought, as per bug 1305151, that we were just going to fuzz with MOZ_SKIA_DISABLE_ASSERTS now? There doesn't seem to be an actual crash if we just disable the assert here...

Comment 2

[Tyson Smith [:tsmith]]

Yes we are fuzzing with MOZ_SKIA_DISABLE_ASSERTS=1 I'm not sure why this is being hit.

I have created a Pernosco session to help debug the issue. https://pernos.co/debug/onsCE2Ylb3GNzGKQGGuuXA/index.html (Note: MOZ_SKIA_DISABLE_ASSERTS=1 was set)

Comment 3

[Lee Salzman [:lsalzman]]

This should be resolved by bug 1645123.