1593188 - Follow movements of search engines in M-C

Status: RESOLVED FIXED

(Thunderbird :: Search, task)

Description

[Jorg K (CEST = GMT+2)]

M-C are reworking their search engine implementation. Let's not open a bug for every little thing that needs to be tweaked.

I'll make a start with porting bug 1592014:
https://hg.mozilla.org/mozilla-central/rev/1e8a2884d6bfda4eddd63150583e189947369fed

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: se-tweaks.patch

This should do it:
Basically copied engines.json from M-C again and repeated the steps from bug 1583383 comment #14 without removing the telemetry IDs:

• removed eBay
• removed extraParams (Yandex, DDG, Bing)
• removed pc MOZI from Bing
• removed tags and client with firefox
• simplified Google appliesTo as suggested
• removed "tn": "monline_7_dg" from Baidu since it wasn't in the WE
• "tag": "mozillajapan-fx-22" and "tag": "mozilla-20" from Amazon, note sourceid=Mozilla-search is in the WEs

Checked JSON at https://jsonformatter.curiousconcept.com/

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d88e7bc9222a02ff0bd757056bdd9ce6fb6fc673

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/94b8a3b37f15
Port bug 1592014: Change the WebExtension parameters of the modern configuration to be an object. rs=bustage-fix

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1593188-remove-engine-name.patch

sed -i -e '/engineName/d' engines.json.
Checked JSON at https://jsonformatter.curiousconcept.com/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8a5adb2c4820
Port bug 1592209: Remove engineName from the modern configuration. r=me

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1593188-port-1595471.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4cc362945059
Port bug 1595471: More tweaks to engines.json. r=me

Comment 7

[Jorg K (CEST = GMT+2)]

Looks like bug 1600715 will need porting if tests blow up.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ecec3c8f000
Port bug 1600715 changes to search engines; rs=bustage-fix DONTBUILD

Comment 9

[Jorg K (CEST = GMT+2)]

A bunch of tests from toolkit/components/search/tests have blown up again.
Last good: 5e69563343eb5bb7b8dfaaacc1e634e57d
First bad: 4f2f9bda72ac1c91576d2ca18d8323fe41
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5e69563343eb5bb7b8dfaaacc1e634e57d&tochange=4f2f9bda72ac1c91576d2ca18d8323fe41

Sadly there were three merges in this range, but anyway, easy to spot the issue: Bug 1590860, bug 1615309 and/or bug 1613348.

As a bustage fix you could likely get away with setting this pref:
https://hg.mozilla.org/mozilla-central/rev/7c6bdadeea29fab3700320515798d84ba3414f4f#l1.12

Comment 10

[Intermittent Failures Robot]

20 failures in 228 pushes (0.088 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 20

Platform breakdown:

• linux32: 4
• macosx1014-64: 4
• linux64: 4
• windows10-64: 4
• windows7-32: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1593188&startday=2020-02-29&endday=2020-02-29&tree=all

Comment 11

[Intermittent Failures Robot]

39 failures in 5233 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #36 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 39

Platform breakdown:

• linux32: 8
• macosx1014-64: 7
• linux64: 8
• windows10-64: 8
• windows7-32: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1593188&startday=2020-02-24&endday=2020-03-01&tree=all

Comment 12

[Jorg K (CEST = GMT+2)]

Any plans to address this?

Comment 13

[Geoff Lankow (:darktrojan)]

This has been dealt with in bug 1619173.

Comment 14

[Jorg K (CEST = GMT+2)]

If you say so. I'm surprised that none of bug 1590860, bug 1615309 and/or bug 1613348 needs further porting. And I put a bazillion incorrect stars onto the tree. I should stop doing so. Sorry.

Let's call this done then. Last landed patch in comment #8 in early Dec. 2019, so that makes it TB 73.

Comment 15

[Jorg K (CEST = GMT+2)]

Hmm, https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=46b1f5963bc766e3ce036c5a17374fa94039db25 has more search failures, but anyway, you'll do them in a new bug.