1593222 - Split notifying mutation observers code off from `nsNodeUtils`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

"Utils" and "Helper" classes are code-smell. They indicate their naming is imprecise.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 1) Move `nsNodeUtils::IsTemplateElement` to `nsINode`. r=smaug

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 2) Move `nsNodeUtils::GetTargetForAnimation` to `Animation` class. r=smaug

Depends on D51606

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 3) Move `nsNodeUtils::GetFirstChildOfTemplateOrNode` to `nsINode`. r=smaug

Depends on D51607

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 4) Move `nsNodeUtils::LastRelease` to `nsINode`. r=smaug

Depends on D51608

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 5) Merge `nsNodeUtils::CloneNodeImpl` into its only caller. r=smaug

Depends on D51609

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 6) Move `nsINodeUtils::Clone` to `nsINode::Clone`. r=smaug

Makes nsNodeUtils::CloneAndAdopt temporarily public. Will be hidden
again in a follow-up commit.

Depends on D51820

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 7) Move `nsNodeUtils::Adopt` to `nsINode`. r=smaug

Depends on D51821

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 8) Move `nsNodeUtils::CloneAndAdopt` to `nsINode`. r=smaug

Depends on D51823

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 9) Move non-animation notification methods from `nsNodeUtils` to `MutationObservers`. r=smaug

The remaining notification methods are moved in a separate commit. The
files are renamed to MutationObservers.* in a follow-up commit.

Depends on D51824

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 10) Move `Animation*` methods to `MutationObservers`. r=smaug

Depends on D51825

Comment 11

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 11) Remove superfluous includes in nsNodeUtils.h. r=smaug

Depends on D51826

Comment 12

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 12) Rename "nsNodeUtils.*" to "MutationObservers.*". r=smaug

Depends on D51827

Comment 13

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1593222: part 13) Include "ReferrerInfo.h" in "nsAttrValue.cpp". r=smaug

Was necessary to get some build working.

Depends on D51828

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0b7bb78df70
part 1) Move `nsNodeUtils::IsTemplateElement` to `nsINode`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d3fdb4d409ee
part 2) Move `nsNodeUtils::GetTargetForAnimation` to `Animation` class. r=smaug
https://hg.mozilla.org/integration/autoland/rev/417b8d40a73a
part 3) Move `nsNodeUtils::GetFirstChildOfTemplateOrNode` to `nsINode`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6e2acc2b423c
part 4) Move `nsNodeUtils::LastRelease` to `nsINode`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4f878983dfdb
part 5) Merge `nsNodeUtils::CloneNodeImpl` into its only caller. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f6ff7a362957
part 6) Move `nsINodeUtils::Clone` to `nsINode::Clone`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/06e69dfdd516
part 7) Move `nsNodeUtils::Adopt` to `nsINode`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a532ea3bcef9
part 8) Move `nsNodeUtils::CloneAndAdopt` to `nsINode`.  r=smaug
https://hg.mozilla.org/integration/autoland/rev/63b6cf4b0e94
part 9) Move non-animation notification methods from `nsNodeUtils` to `MutationObservers`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/99e3838c201b
part 10) Move `Animation*` methods to `MutationObservers`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e16e70d278de
part 11) Remove superfluous includes in nsNodeUtils.h. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a017e363de4f
part 12) Rename "nsNodeUtils.*" to "MutationObservers.*". r=smaug
https://hg.mozilla.org/integration/autoland/rev/8510e2594e5f
part 13) Include "ReferrerInfo.h" in "nsAttrValue.cpp". r=smaug

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d0b7bb78df70
https://hg.mozilla.org/mozilla-central/rev/d3fdb4d409ee
https://hg.mozilla.org/mozilla-central/rev/417b8d40a73a
https://hg.mozilla.org/mozilla-central/rev/6e2acc2b423c
https://hg.mozilla.org/mozilla-central/rev/4f878983dfdb
https://hg.mozilla.org/mozilla-central/rev/f6ff7a362957
https://hg.mozilla.org/mozilla-central/rev/06e69dfdd516
https://hg.mozilla.org/mozilla-central/rev/a532ea3bcef9
https://hg.mozilla.org/mozilla-central/rev/63b6cf4b0e94
https://hg.mozilla.org/mozilla-central/rev/99e3838c201b
https://hg.mozilla.org/mozilla-central/rev/e16e70d278de
https://hg.mozilla.org/mozilla-central/rev/a017e363de4f
https://hg.mozilla.org/mozilla-central/rev/8510e2594e5f