1593223 - 0 - 5363.46% compiler_metrics num_static_constructors (linux64-aarch64) regression on push 79947a8fd084fb8022cbabda91c69629b11049d1 (Thu October 31 2019)

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Marian Raiciof [:marauder]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=79947a8fd084fb8022cbabda91c69629b11049d1

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

5363% compiler_metrics num_static_constructors linux64-aarch64 opt 4.33 -> 236.75
0.00% compiler_metrics num_static_constructors linux64-aarch64 opt 0.00 -> 222.00

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23649

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Nathan Froyd [:froydnj]]

Given that we've gone from 0 to 200+, I suspect what was happening was that we weren't actually measuring things correctly prior to this. And we're not shipping these builds, so I'm not worried about static constructors on this platform (although it is a bit unusual that we have so many more on aarch64 than we do on x86-64...).

Comment 2

[(Away)]

(In reply to Nathan Froyd [:froydnj] from comment #1)

(although it is a bit unusual that we have so many more on aarch64 than we do on x86-64...).

I suspect that this was crosstalk from bug 1593217 occurring in close proximity: https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&series=autoland,1954906,1,2&timerange=1209600&zoom=1572413657251,1572539902846,-12.534803921568596,318.1452614379085