1593224 - Port Bug 1516091 to Thunderbird (remove sidebarheader element, convert to <box class="sidebar-header">)

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

Bug 1516091 is getting rid of <sidebarheader>

Per Tim's comment: "I guess they could be changed to box class="sidebar-header" and the styling could be ported over."

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1593224_sidebarheader.patch

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9105764 [details] [diff] [review]
bug1593224_sidebarheader.patch

Review of attachment 9105764 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r+ with the comments considered.

Patch can land without waiting for the M-C bug.

::: mail/base/content/messenger.xul
@@ +494,5 @@
>  #include mainMailToolbox.inc.xul
>  
>            <box id="messengerBox" orient="horizontal" flex="1" minheight="100" height="100" persist="height">
>              <vbox id="folderPaneBox" minwidth="125" width="200" persist="width">
> +              <box id="folderPaneHeader" class="sidebar-header" hidden="true" align="center"/>

Shouldn't we remove this header with the CSS rules? It seem never used.

::: mail/themes/shared/mail/messengercompose.css
@@ +155,5 @@
>      list-style-image: var(--webextension-menuitem-image-2x, inherit) !important;
>    }
>  }
>  
> +.sidebar-header {

This and the following rule aren't needed because the ones from messenger.css are already used.

Comment 3

[Magnus Melin [:mkmelin]]

(In reply to Richard Marti (:Paenglab) from comment #2)

Shouldn't we remove this header with the CSS rules? It seem never used.

Yeah let's remove it.

This and the following rule aren't needed because the ones from
messenger.css are already used.

Ah, I missed that.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1593224_sidebarheader.patch

Addressed review comments.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8aa9c7cbd3f9
Port bug 1516091: remove sidebarheader element, convert to <box class="sidebar-header">. r=Paenglab