Closed Bug 1593224 Opened 5 months ago Closed 5 months ago

Port Bug 1516091 to Thunderbird (remove sidebarheader element, convert to <box class="sidebar-header">)

Categories

(Thunderbird :: General, task, P1)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1516091 is getting rid of <sidebarheader>

Per Tim's comment: "I guess they could be changed to box class="sidebar-header" and the styling could be ported over."

Priority: -- → P1
Summary: Port Bug 1516091 to Thunderbird (convert/remove sidebarheader element) → Port Bug 1516091 to Thunderbird (remove sidebarheader element, convert to <box class="sidebar-header">)
Attached patch bug1593224_sidebarheader.patch (obsolete) — Splinter Review
Attachment #9105764 - Flags: review?(richard.marti)
Status: NEW → ASSIGNED
Comment on attachment 9105764 [details] [diff] [review]
bug1593224_sidebarheader.patch

Review of attachment 9105764 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r+ with the comments considered.

Patch can land without waiting for the M-C bug.

::: mail/base/content/messenger.xul
@@ +494,5 @@
>  #include mainMailToolbox.inc.xul
>  
>            <box id="messengerBox" orient="horizontal" flex="1" minheight="100" height="100" persist="height">
>              <vbox id="folderPaneBox" minwidth="125" width="200" persist="width">
> +              <box id="folderPaneHeader" class="sidebar-header" hidden="true" align="center"/>

Shouldn't we remove this header with the CSS rules? It seem never used.

::: mail/themes/shared/mail/messengercompose.css
@@ +155,5 @@
>      list-style-image: var(--webextension-menuitem-image-2x, inherit) !important;
>    }
>  }
>  
> +.sidebar-header {

This and the following rule aren't needed because the ones from messenger.css are already used.
Attachment #9105764 - Flags: review?(richard.marti) → review+

(In reply to Richard Marti (:Paenglab) from comment #2)

Shouldn't we remove this header with the CSS rules? It seem never used.

Yeah let's remove it.

This and the following rule aren't needed because the ones from
messenger.css are already used.

Ah, I missed that.

Addressed review comments.

Attachment #9105764 - Attachment is obsolete: true
Attachment #9105799 - Flags: review+
Target Milestone: --- → Thunderbird 72.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8aa9c7cbd3f9
Port bug 1516091: remove sidebarheader element, convert to <box class="sidebar-header">. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.