1593246 - Make current session storage implementation Fission-compatible

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P1)

Description

[Yaron Tausky [:ytausky]]

When the frame is replaced from example.org in process A to example.com the new page is loaded in another process B, but when the frame is replaced again back to example.org it lands in a third process C, which doesn't have session storage data from process A.

Comment 1

[Yaron Tausky [:ytausky]]

My current understanding of what needs to be done:

1. When navigating a window, all of its session storage entries (transitively including nested windows) need to be sent to the parent process.
2. When loading a document in a window, all session storage entries for the document's origin need to get fetched from the parent process and populated before any scripts are run.
3. Since sessionstore also needs this information and collects it periodically, the existing code could be partially reused.

Jan, please have a look when you're back and let me know if that's correct.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

This may be connected to bug 1445464, as avoiding copying this data around during navigations should help with preserving it.

Comment 3

[Yaron Tausky [:ytausky]]

It's related, but we won't be able to get to that for a while, so we'll need to get the current implementation to work with Fission.

Comment 4

[Yaron Tausky [:ytausky]]

BTW, here's a Pernosco session running dom/tests/mochitest/sessionstorage/test_sessionStorageReplace.html (and failing).

Comment 5

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 6

[Chris Peterson [:cpeterson]]

Tracking session storage work for Fission Nightly milestone (M6).

Comment 7

[Yaron Tausky [:ytausky]]

Attachment: Bug 1593246 - Part 1: Move SessionStorageManager to BrowsingContext r=#dom-workers-and-storage-reviewers

With Fission enabled we do not necessarily have access to the
nsDocShell that holds the top-level browsing context, so the
BrowsingContext is a better place to store information that needs
to be accessible to nested browsing contexts.

Comment 8

[Yaron Tausky [:ytausky]]

Attachment: Bug 1593246 - Part 2: Give SessionStorageManager a reference to BrowsingContext r=#dom-workers-and-storage-reviewers

This reference is necessary when sending session storage data for
all browsing context to the parent process. Note that it entails
making SessionStorageManager a cycle collection participant, since
adding this reference creates a cycle.

Depends on D55276

Comment 9

[Yaron Tausky [:ytausky]]

Attachment: Bug 1593246 - Part 3: Remove unused parameter from SessionStorageManager::GetSessionStorageCacheHelper r=#dom-workers-and-storage-reviewers

Depends on D55659

Comment 10

[Yaron Tausky [:ytausky]]

Attachment: Bug 1593246 - Part 4: Overload SessionStorageManager::GetSessionStorageCacheHelper r=#dom-workers-and-storage-reviewers

Depends on D55660

Comment 11

[Yaron Tausky [:ytausky]]

Attachment: Bug 1593246 - Part 5: Replicate session storage data r=janv,asuth

This commit implements a simple data replication scheme, where
each content process receives a copy of the relevant session
storage data when navigating, and sending all its session storage
data to the parent process before shutting down.

Depends on D55661

Comment 12

[Chris Peterson [:cpeterson]]

Resetting Fission milestone to M4.1. Yaron pointed out that this bug is about sessionStorage, not session restore. :)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9f0d827e28d
Part 1: Move SessionStorageManager to BrowsingContext r=dom-workers-and-storage-reviewers,sg,smaug
https://hg.mozilla.org/integration/autoland/rev/2663311a1b62
Part 2: Give SessionStorageManager a reference to BrowsingContext r=sg
https://hg.mozilla.org/integration/autoland/rev/fd389138a684
Part 3: Remove unused parameter from SessionStorageManager::GetSessionStorageCacheHelper r=dom-workers-and-storage-reviewers,sg

Comment 14

[Razvan Maries]

Backed out for build bustages on BrowsingContext.h.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=280329217&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2C%28bb%29&revision=fd389138a684c35685d93bf9c7e976aba106cdab

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280329217&repo=autoland&lineNumber=17361

Backout: https://hg.mozilla.org/integration/autoland/rev/922cb699c35184ba8825d404480a1fa873bbb11b

Comment 15

[Andreea Pavel [:apavel]]

This also caused bug 1484492 to perma-fail:

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64-qr%2Fdebug-mochitest-fis-e10s-2%2Cm-fis%282%29&fromchange=fd389138a684c35685d93bf9c7e976aba106cdab&tochange=922cb699c35184ba8825d404480a1fa873bbb11b

Comment 16

[Yaron Tausky [:ytausky]]

I fixed the problem and will try to land the patches again tomorrow.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/433fd567ff92
Part 1: Move SessionStorageManager to BrowsingContext r=dom-workers-and-storage-reviewers,sg,smaug
https://hg.mozilla.org/integration/autoland/rev/c11ce752a12e
Part 2: Give SessionStorageManager a reference to BrowsingContext r=sg
https://hg.mozilla.org/integration/autoland/rev/44fb598d3ad8
Part 3: Remove unused parameter from SessionStorageManager::GetSessionStorageCacheHelper r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/de6b543ce6d7
Part 4: Overload SessionStorageManager::GetSessionStorageCacheHelper r=dom-workers-and-storage-reviewers,asuth

Comment 18

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/433fd567ff92
https://hg.mozilla.org/mozilla-central/rev/c11ce752a12e
https://hg.mozilla.org/mozilla-central/rev/44fb598d3ad8
https://hg.mozilla.org/mozilla-central/rev/de6b543ce6d7

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aea23435804b
Part 5: Replicate session storage data r=janv,asuth

Comment 20

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/aea23435804b