Closed Bug 1593260 Opened 5 years ago Closed 5 years ago

GCVector::sweep calls std::remove_if with a predicate that modifies its argument

Categories

(Core :: JavaScript: GC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

As pointed out by anba, this is not allowed. I broke this in bug 1589717.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/531936128441
Don't use remove_if for sweeping GCVector as the predicate can modify the elements r=anba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: