Closed Bug 1593439 Opened 5 years ago Closed 5 years ago

Perma TEST-UNEXPECTED-FAIL | toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js | Test timed out - when Gecko 72 merges to Beta on 2019-12-02

Tracking

()

Status:

VERIFIED FIXED

Milestone:

mozilla72

Tracking Flags:

Tracking

Status

firefox-esr68

---

unaffected

firefox70

---

unaffected

firefox71

---

unaffected

firefox72

verified

People

(Reporter: apavel, Assigned: CuveeHsu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1593439 - always use document channel to test coop for beta simulation, r=valentin 5 years ago Junior [inactive] 47 bytes, text/x-phabricator-request		Details \| Review

Andreea Pavel [:apavel]

Reporter

Description

•

5 years ago

[Tracking Requested - why for this release]:

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7615639a6ca7cad0078a854e1331d7a58444619a&selectedJob=274212032

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274211840&repo=try&lineNumber=14831

[task 2019-11-02T11:41:57.413Z] 11:41:57 INFO - GECKO(5380) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpcpTKGB.mozrunner/runtests_leaks_tab_pid5644.log
[task 2019-11-02T11:41:57.428Z] 11:41:57 INFO - GECKO(5380) | [Child 5644, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-11-02T11:41:57.456Z] 11:41:57 INFO - GECKO(5380) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-02T11:41:57.572Z] 11:41:57 INFO - GECKO(5380) | Waiting for browser load
[task 2019-11-02T11:41:57.613Z] 11:41:57 INFO - GECKO(5380) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-02T11:41:57.674Z] 11:41:57 INFO - GECKO(5380) | [Child 5633, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1787
[task 2019-11-02T11:41:57.690Z] 11:41:57 INFO - GECKO(5380) | ++DOCSHELL 0x7fa8b4a76800 == 1 [pid = 5633] [id = {93028428-14f4-4d7c-aa0d-c9d374ba9656}]
[task 2019-11-02T11:41:57.806Z] 11:41:57 INFO - GECKO(5380) | ++DOMWINDOW == 1 (0x7fa8b59ecf20) [pid = 5633] [serial = 1] [outer = (nil)]
[task 2019-11-02T11:41:57.807Z] 11:41:57 INFO - GECKO(5380) | ++DOMWINDOW == 2 (0x7fa8b4a12400) [pid = 5633] [serial = 2] [outer = 0x7fa8b59ecf20]
[task 2019-11-02T11:41:57.823Z] 11:41:57 INFO - GECKO(5380) | [Child 5644, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1787
[task 2019-11-02T11:41:57.831Z] 11:41:57 INFO - GECKO(5380) | ++DOCSHELL 0x7f9c8af75800 == 1 [pid = 5644] [id = {3ae84830-f89a-4b30-ae0e-5c3dd7ca3e21}]
[task 2019-11-02T11:41:57.891Z] 11:41:57 INFO - GECKO(5380) | ++DOMWINDOW == 1 (0x7f9c8c0a1f20) [pid = 5644] [serial = 1] [outer = (nil)]
[task 2019-11-02T11:41:57.899Z] 11:41:57 INFO - GECKO(5380) | ++DOMWINDOW == 2 (0x7f9c8c0d4000) [pid = 5644] [serial = 2] [outer = 0x7f9c8c0a1f20]
[task 2019-11-02T11:41:58.097Z] 11:41:58 INFO - GECKO(5380) | Saw state f0001 and status 0
[task 2019-11-02T11:41:58.141Z] 11:41:58 INFO - [5359, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173

[task 2019-11-02T11:43:27.815Z] 11:43:27 INFO -
[task 2019-11-02T11:43:27.816Z] 11:43:27 INFO - TEST-PASS | toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js | 5644 == 5644 -
[task 2019-11-02T11:43:27.817Z] 11:43:27 INFO - Console message: [JavaScript Error: "RemoteWebProgress failed to call onProgressChange: [Exception... "JavaScript component does not have a method named: "onProgressChange"'JavaScript component does not have a method named: "onProgressChange"' when calling method: [nsIWebProgressListener::onProgressChange]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: resource://gre/modules/RemoteWebProgress.jsm :: _callProgressListeners :: line 75" data: no]
[task 2019-11-02T11:43:27.817Z] 11:43:27 INFO - " {file: "resource://gre/modules/RemoteWebProgress.jsm" line: 77}]
[task 2019-11-02T11:43:27.818Z] 11:43:27 INFO - _callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:77:14
[task 2019-11-02T11:43:27.818Z] 11:43:27 INFO - onProgressChange@resource://gre/modules/RemoteWebProgress.jsm:104:10
[task 2019-11-02T11:43:27.818Z] 11:43:27 INFO -
[task 2019-11-02T11:43:27.818Z] 11:43:27 INFO - Buffered messages finished
[task 2019-11-02T11:43:27.818Z] 11:43:27 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js | Test timed out -
[task 2019-11-02T11:43:27.819Z] 11:43:27 INFO - GECKO(5380) | MEMORY STAT | vsize 2965MB | residentFast 348MB | heapAllocated 110MB
[task 2019-11-02T11:43:27.820Z] 11:43:27 INFO - TEST-OK | toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js | took 90032ms
[task 2019-11-02T11:43:27.820Z] 11:43:27 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-02T11:43:27.820Z] 11:43:27 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js | Found a tab after previous test timed out: https://example.org/browser/toolkit/components/remotebrowserutils/tests/browser/coop_header.sjs?coop=same-origin -
[task 2019-11-02T11:43:27.821Z] 11:43:27 INFO - GECKO(5380) | ++DOCSHELL 0x7fd4c3ad3000 == 1 [pid = 5507] [id = {1edfcff8-9c19-4617-b613-68e6469febdd}]
[task 2019-11-02T11:43:27.821Z] 11:43:27 INFO - GECKO(5380) | ++DOMWINDOW == 3 (0x7fd4c351b2e0) [pid = 5507] [serial = 3] [outer = (nil)]
[task 2019-11-02T11:43:27.824Z] 11:43:27 INFO - GECKO(5380) | ++DOMWINDOW == 4 (0x7fd4c3130c00) [pid = 5507] [serial = 4] [outer = 0x7fd4c351b2e0]
[task 2019-11-02T11:43:27.825Z] 11:43:27 INFO - GECKO(5380) | ++DOMWINDOW == 5 (0x7fd4c3137c00) [pid = 5507] [serial = 5] [outer = 0x7fd4c351b2e0]
[task 2019-11-02T11:43:27.825Z] 11:43:27 INFO - checking window state

Tom is this from bug 1562667?

Flags: needinfo?(ttung)

Tom Tung [:tt, :ttung]

Comment 1

•

5 years ago

I don't think so. bug 1562667 is related to window.postMessage and it's protected by a pref (dom_postMessage_sharedArrayBuffer_withCOOP_COEP; default off on all channel except the wpt test). And I couldn't find window.postMessage in this test by simply search the keyword.

Hi Valentin,

Does this test browser_httpCrossOriginOpenerPolicy.js test the logic for window.postMessage? Or, maybe you have something in your mind? Please feel free to let me know if it tests the logic for window.postMessage and then I will look into it more. Thanks!

Flags: needinfo?(ttung) → needinfo?(valentin.gosu)

Tom Tung [:tt, :ttung]

Updated

•

5 years ago

No longer regressed by: 1562667

Valentin Gosu [:valentin] (he/him)

Comment 2

•

5 years ago

(In reply to Tom Tung [:tt, :ttung] from comment #1)

Does this test browser_httpCrossOriginOpenerPolicy.js test the logic for window.postMessage?

Not directly, but maybe BrowserTestUtils.browserStopped or BrowserTestUtils.loadURI use that in some way?
It's also possible there's another pref that should be set in the test.

Andrea, do you know if I can build the beta simulation locally so I can debug the test?

Flags: needinfo?(valentin.gosu) → needinfo?(apavel)

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 3

•

5 years ago

Bisection narrows it to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=23c113d65b48353d5ce085fd0c7f67d3604bd244&tochange=87443484a46af1eca23f465b6d9bfedfa8d82a20

Honza: Paul is on PTO, can you take care of this or needinfo :sdetar, please?

Flags: needinfo?(apavel)

Regressed by: 1588412

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 4

•

5 years ago

Similar to the other two regressions from bug 1588412.

Flags: needinfo?(honzab.moz)

Julien Cristau [:jcristau]

Updated

•

5 years ago

tracking-firefox72: ? → +

Junior [inactive]

Assignee

Comment 5

•

5 years ago

(In reply to Valentin Gosu [:valentin] (he/him) from comment #2)

(In reply to Tom Tung [:tt, :ttung] from comment #1)

Does this test browser_httpCrossOriginOpenerPolicy.js test the logic for window.postMessage?

Not directly, but maybe BrowserTestUtils.browserStopped or BrowserTestUtils.loadURI use that in some way?
It's also possible there's another pref that should be set in the test.

Andrea, do you know if I can build the beta simulation locally so I can debug the test?

I have similar question and this works (thanks :aryx)

https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA
Run the command with the mentioned --no-push argument and you get the changes locally.
Commit them as hg commit -m "Early beta config" and run ./mach build

Junior [inactive]

Assignee

Updated

•

5 years ago

Comment 6

•

5 years ago

I did a local test on this bug and bug 1593445 and this patch breaks process switch trigger by COOP (with document channel off).

BugBot [:suhaib / :marco/ :calixte]

Updated

•

5 years ago

Keywords: regression

Honza Bambas (:mayhemer)

Comment 7

•

5 years ago

Not sure what info is needed from me here.

Flags: needinfo?(honzab.moz)

Junior [inactive]

Assignee

Comment 8

•

5 years ago

Valentin mentioned we need to ship re-SAB with document channel, therefore we can assume the document pref is on here.

Junior [inactive]

Assignee

Comment 9

•

5 years ago

Attached file Bug 1593439 - always use document channel to test coop for beta simulation, r=valentin — Details

Andreea Pavel [:apavel]

Reporter

Updated

•

5 years ago

Regressions: 1595284

Andreea Pavel [:apavel]

Reporter

Comment 10

•

5 years ago

Importing the patch solves the current issue, however caused bug 1595284.

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=938cfeed4b3bbe8f2f074887acee03756459ba34&selectedJob=275474934

Pulsebot

Comment 11

•

5 years ago

Pushed by juhsu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/453108aa1e96
always use document channel to test coop for beta simulation, r=valentin

Cosmin Sabou [:CosminS]

Comment 12

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/453108aa1e96

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox72: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla72

BugBot [:suhaib / :marco/ :calixte]

Updated

•

5 years ago

Assignee: nobody → juhsu

Alexandru Michis [:malexandru]

Comment 13

•

5 years ago

Verified fixed in today's central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=d0ba5ea886d9a30f46817ff79edc05fa5f85d411&searchStr=%28bc

Status: RESOLVED → VERIFIED

status-firefox72: fixed → verified

Ryan VanderMeulen [:RyanVM]

Updated

•

5 years ago

status-firefox-esr68: --- → unaffected

BugBot [:suhaib / :marco/ :calixte]

Updated

•

2 years ago

Has Regression Range: --- → yes

You need to log in before you can comment on or make changes to this bug.