Build errors [E0204] and [E0119] on Rust 1.39
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
People
(Reporter: laharlxetna, Unassigned)
Details
Attachments
(1 file)
|
57.35 KB,
text/plain
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
Building Firefox v70 against Rust 1.39 fails with multiple instances of [E0204] and [E0119].
Building against Rust 1.38 succeeds as expected.
Actual results:
See attachment for full list of build errors against rust 1.39.
Expected results:
Build should complete successfully.
|
||
Comment 1•6 years ago
|
||
This seems more like a bug from having different libclang versions. Do you know which libclang version are you using?
You can see what are you using looking at objdir/config.log, for example, locally:
INFO: checking for libclang for bindgen...
DEBUG: Executing: `/home/emilio/.mozbuild/clang/bin/clang++ -print-search-dirs`
DEBUG: Trying "libclang.so" in "/home/emilio/.mozbuild/clang/lib"
INFO: /home/emilio/.mozbuild/clang/lib/libclang.so
INFO: checking that libclang is new enough...
INFO: yes
|
|
||
Comment 2•6 years ago
|
||
I just tried to build with rust 1.39 and it worked fine for me, so yeah, there's something else going on.
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
This seems more like a bug from having different libclang versions. Do you know which libclang version are you using?
You can see what are you using looking at objdir/config.log, for example, locally:
INFO: checking for libclang for bindgen... DEBUG: Executing: `/home/emilio/.mozbuild/clang/bin/clang++ -print-search-dirs` DEBUG: Trying "libclang.so" in "/home/emilio/.mozbuild/clang/lib" INFO: /home/emilio/.mozbuild/clang/lib/libclang.so INFO: checking that libclang is new enough... INFO: yes
I'm using Debian 10, and the git version of LLVM just prior to the release of LLVM 9.0. This is the only version of LLVM and Clang available on my system.
|
|
||
Comment 4•6 years ago
|
||
Ah, I know what this is. This is https://github.com/rust-lang/rust-bindgen/pull/1627 not being in Firefox 70.
So this was fixed in 71 (bug 1583471), and there's not that much we can do modulo uplifting the patch in that bug to fix it.
You can apply that patch locally, but it seems unlikely we'll uplift it at this point, given it's not an ESR release and the supported version to build it was not 1.39...
That being said if you have a strong reason feel free to request uplift on that bug.
|
|
Reporter | |
Comment 5•6 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
Ah, I know what this is. This is https://github.com/rust-lang/rust-bindgen/pull/1627 not being in Firefox 70.
So this was fixed in 71 (bug 1583471), and there's not that much we can do modulo uplifting the patch in that bug to fix it.
You can apply that patch locally, but it seems unlikely we'll uplift it at this point, given it's not an ESR release and the supported version to build it was not 1.39...
That being said if you have a strong reason feel free to request uplift on that bug.
*** This bug has been marked as a duplicate of bug 1583471 ***
Fixed in Firefox 71, you say?
Okay, I will try a build of Firefox 71 beta 9 (https://ftp.mozilla.org/pub/firefox/releases/71.0b7/) and see if I can perform a successful build with Rust 1.39.
|
|
Reporter | |
Comment 6•6 years ago
|
||
I can confirm that v71 builds in Rust 1.39. Thanks for the advice and info.
Description
•