1593469 - Port bug 1470510 to Thunderbird | Merge nsXULWindow and nsWebShellWindow

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1470510 +++

Need to rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1593469_xulwin.patch

Untested

Comment 2

[Jorg K (CEST = GMT+2)]

Bug 1470510 landed and got backed out. So who's going to review this? Geoff?

Comment 3

[Magnus Melin [:mkmelin]]

I tried compiling with the patches from bug 1470510, but it doesn't compile for me. So hard to check yet.

/home/magnus/Code/tb/mozilla/dom/base/nsGlobalWindowOuter.h:465:32: error: member access into incomplete type 'mozilla::dom::BrowsingContext'
return GetBrowsingContext()->HadOriginalOpener();

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1593469_xulwin.patch

Removed one wrong change in test-notification.js. The others look ok I think.

Comment 5

[Jorg K (CEST = GMT+2)]

I tried compiling with the patches from bug 1470510, but it doesn't compile for me.

Then they forgot an include file and we'd be busted. But it just got backed out again.

Comment 6

[Jorg K (CEST = GMT+2)]

I asked them to fix the compile error and here's a try for you, please check the results:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a587853bb731ab49b946b78b9bfa65021ede12cd
based on https://hg.mozilla.org/try/rev/1e73726261fbe050cf89f686d53ad1a82305c49e

Comment 7

[Jorg K (CEST = GMT+2)]

Green try.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9106452 [details] [diff] [review]
bug1593469_xulwin.patch

I think I've looked at this for long enough that I can add the r+ here.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/edadee96ce81
Port bug 1470510: Merge nsXULWindow and nsWebShellWindow. r=jorgk