Closed Bug 1593469 Opened 5 months ago Closed 5 months ago

Port bug 1470510 to Thunderbird | Merge nsXULWindow and nsWebShellWindow

Categories

(Thunderbird :: General, task, P1)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1470510 +++

Need to rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow.

Attached patch bug1593469_xulwin.patch (obsolete) — Splinter Review

Untested

Assignee: nobody → mkmelin+mozilla

Bug 1470510 landed and got backed out. So who's going to review this? Geoff?

Flags: needinfo?(geoff)

I tried compiling with the patches from bug 1470510, but it doesn't compile for me. So hard to check yet.

/home/magnus/Code/tb/mozilla/dom/base/nsGlobalWindowOuter.h:465:32: error: member access into incomplete type 'mozilla::dom::BrowsingContext'
return GetBrowsingContext()->HadOriginalOpener();

Removed one wrong change in test-notification.js. The others look ok I think.

Attachment #9105994 - Attachment is obsolete: true
Attachment #9106452 - Flags: review?(geoff)
Status: NEW → ASSIGNED

I tried compiling with the patches from bug 1470510, but it doesn't compile for me.

Then they forgot an include file and we'd be busted. But it just got backed out again.

Flags: needinfo?(geoff)
Flags: needinfo?(mkmelin+mozilla)

Green try.

Flags: needinfo?(mkmelin+mozilla)
Comment on attachment 9106452 [details] [diff] [review]
bug1593469_xulwin.patch

I think I've looked at this for long enough that I can add the r+ here.
Attachment #9106452 - Flags: review?(geoff) → review+
Target Milestone: --- → Thunderbird 72.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/edadee96ce81
Port bug 1470510: Merge nsXULWindow and nsWebShellWindow. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.