Port bug 1470510 to Thunderbird | Merge nsXULWindow and nsWebShellWindow
Categories
(Thunderbird :: General, task, P1)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file, 1 obsolete file)
24.02 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1470510 +++
Need to rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow.
Comment 2•4 years ago
|
||
Bug 1470510 landed and got backed out. So who's going to review this? Geoff?
Assignee | ||
Comment 3•4 years ago
|
||
I tried compiling with the patches from bug 1470510, but it doesn't compile for me. So hard to check yet.
/home/magnus/Code/tb/mozilla/dom/base/nsGlobalWindowOuter.h:465:32: error: member access into incomplete type 'mozilla::dom::BrowsingContext'
return GetBrowsingContext()->HadOriginalOpener();
Assignee | ||
Comment 4•4 years ago
|
||
Removed one wrong change in test-notification.js. The others look ok I think.
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
I tried compiling with the patches from bug 1470510, but it doesn't compile for me.
Then they forgot an include file and we'd be busted. But it just got backed out again.
Comment 6•4 years ago
|
||
I asked them to fix the compile error and here's a try for you, please check the results:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a587853bb731ab49b946b78b9bfa65021ede12cd
based on https://hg.mozilla.org/try/rev/1e73726261fbe050cf89f686d53ad1a82305c49e
Comment 8•4 years ago
•
|
||
Comment on attachment 9106452 [details] [diff] [review] bug1593469_xulwin.patch I think I've looked at this for long enough that I can add the r+ here.
Updated•4 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/edadee96ce81
Port bug 1470510: Merge nsXULWindow and nsWebShellWindow. r=jorgk
Description
•