1593474 - firefox 71 requires NSPR 4.23, but it's not set correctly in its scripts.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[tt_1]

Attachment: build.log.zip

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

compiled firefox-71.0_beta6 on arm

Actual results:

the build failed with this error:

19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSComponent.cpp: In function 'mozilla::UniqueCERTCertList mozilla::psm::FindNonCACertificatesWithPrivateKeys()':
19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSComponent.cpp:2214:34: error: 'PK11_GetCertsMatchingPrivateKey' was not declared in this scope
19:29.79 UniqueCERTCertList certs(PK11_GetCertsMatchingPrivateKey(node->key));
19:29.79 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSComponent.cpp:2214:34: note: suggested alternative: 'PK11_GetCertFromPrivateKey'
19:29.79 UniqueCERTCertList certs(PK11_GetCertsMatchingPrivateKey(node->key));
19:29.79 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
19:29.79 PK11_GetCertFromPrivateKey
19:29.79 In file included from Unified_cpp_security_manager_ssl2.cpp:29:
19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSIOLayer.cpp: In function 'nsresult nsSSLIOLayerSetOptions(PRFileDesc*, bool, bool, const char*, int32_t, nsNSSSocketInfo*)':
19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSIOLayer.cpp:2207:7: error: 'SSL_CipherSuiteOrderGet' was not declared in this scope
19:29.79 if (SSL_CipherSuiteOrderGet(fd, ciphers.data(), &enabledCiphers) !=
19:29.79 ^~~~~~~~~~~~~~~~~~~~~~~
19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSIOLayer.cpp:2207:7: note: suggested alternative: 'SSL_CipherPrefGet'
19:29.79 if (SSL_CipherSuiteOrderGet(fd, ciphers.data(), &enabledCiphers) !=
19:29.79 ^~~~~~~~~~~~~~~~~~~~~~~
19:29.79 SSL_CipherPrefGet
19:29.79 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSIOLayer.cpp:2221:11: error: 'SSL_CipherSuiteOrderSet' was not declared in this scope
19:29.79 if (SSL_CipherSuiteOrderSet(fd, ciphers.data(), enabledCiphers) !=
19:29.79 ^~~~~~~~~~~~~~~~~~~~~~~
19:29.80 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSIOLayer.cpp:2221:11: note: suggested alternative: 'SSL_CipherPrefSet'
19:29.80 if (SSL_CipherSuiteOrderSet(fd, ciphers.data(), enabledCiphers) !=
19:29.80 ^~~~~~~~~~~~~~~~~~~~~~~
19:29.80 SSL_CipherPrefSet
19:29.80 In file included from Unified_cpp_security_manager_ssl2.cpp:38:
19:29.80 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-71.0_beta6/work/firefox-71.0/security/manager/ssl/nsNSSModule.cpp: In instantiation of 'nsresult mozilla::psm::Instantiate(const nsIID&, void**) [with InstanceClass = nsCertOverrideService; nsresult (InstanceClass::* InitMethod)() = &nsCertOverrideService::Init; nsIID = nsID]':

the full build log is attached

Expected results:

it should have compiled successfully

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[tt_1]

an educated guess

Comment 3

[J.C. Jones [:jcj] (he/him)]

This implies that NSS isn't up-to-date, in some fashion here.

Firefox 71 requires NSS 3.47 (https://hg.mozilla.org/releases/mozilla-beta/file/tip/old-configure.in#l1515), but the ebuild must be still referring to an earlier version - likely 3.46.1. Note it'll also require NSPR 4.23. Check on those dependencies if you would and let me know if that's the source of the issue, or if we have something else wrong in the release.

Thanks!

Comment 4

[tt_1]

I'm going to try again, but the config script only checks for >=nspr-4.21, that's for sure.

Comment 5

[tt_1]

Indeed, I think the problem was the lack of =nspr-4.23 , =nspr-4.21 is too old. Please update the config file accordingly.

Comment 6

[J.C. Jones [:jcj] (he/him)]

[Tracking Requested - why for this release]:

Ahhh, NSPR team didn't update old-configure.in. Got it. Let's get that fixed in the beta branch!

OK, regressed by bug 1586867. Thanks for the report!

Comment 7

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1593474 - Require NSPR 4.23 in old-configure.in

The patch for bug 1586867 should have updated old-configure.in but didn't.

Comment 8

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 9106269 [details]
Bug 1593474 - Require NSPR 4.23 in old-configure.in

Beta/Release Uplift Approval Request

• User impact if declined: If declined, our Firefox 71 sources won't build from the makefiles.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is mostly for distributions that use our makefiles to make dependency decisions. We know NSPR 4.23 works fine, we just want everyone to use it.
• String changes made/needed: none

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99fc19f68c76
Require NSPR 4.23 in old-configure.in r=kaie

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/99fc19f68c76

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9106269 [details]
Bug 1593474 - Require NSPR 4.23 in old-configure.in

Low risk NSPR fix for downstream users of Firefox, uplift approved for 71 beta 8, thanks.

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1cb64c38f1c5