Closed Bug 1593544 Opened 5 months ago Closed 5 months ago

TEST-UNEXPECTED-FAIL | comm/common/test/xpcshell/test_bootstrap.js | xpcshell return code: 0

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

Details

Attachments

(2 files)

First seen here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=8aa9c7cbd3f94bb90393e5c4a3b34a27bc147d14&selectedJob=274276018

Sorry, not many patches available this weekend, so we have one run on Friday night, plus Saturday's and Sunday's Daily on the same C-C changeset :-(

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8aa8ed80ea4325031cd613b5f85a3d6942&tochange=3e02f4745b0d6fb8eb395cbb81d4bc9098

To me it looks like coming from this:
16d21676bcb9d75a488d25ac67f536331899b959 Gijs Kruitbosch — Bug 1545123 - move reading pluginreg and scanning for plugins to a background thread, r=handyman,mconley
ddaad03e2e35369282130e5ec35c0a5b6ed22400 Gijs Kruitbosch — Bug 1545123 - move plugin finding into its own class to clarify dependencies and data flows, r=handyman
ccb230067cd9942b379dcf909fd1b7d222905cec Gijs Kruitbosch — Bug 1545123 - remove obsolete things from nsPluginHost, r=handyman
1facb4403c96f742879e63f418955a1ad93772b3 Gijs Kruitbosch — Bug 1545123 - simplify how we get directory information for plugins, r=handyman,mconley
dc85aaeb9ee91f2df0a5c03106538138a9adbadb Gijs Kruitbosch — Bug 1545123 - store flash information in prefs instead of pluginreg, r=handyman

Flags: needinfo?(geoff)
Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a4dc1186265b
disable failing test_bootstrap.js. rs=bustage-fix

0:02.42 INFO "CONSOLE_MESSAGE: (error) [JavaScript Error: "gPluginPageListener is null" {file: "resource://gre/modules/AddonManager.jsm" line: 1131}]
ERROR Wasn't expecting events for Shockwave FlashFlash plug-in for testing purposes.
0:02.45 INFO "CONSOLE_MESSAGE: (error) [JavaScript Error: "TypeError: setting getter-only property "gLogEnabled"" {file: "resource://gre/modules/UpdateTimerManager.jsm" line: 352}]"

:-(

I think the best solution would be to stop loading the PluginProvider.jsm for Thunderbird, since we don't support plug-ins in any form any more. I think we can also stop loading GMPProvider.jsm, because we don't use Widevine or the OpenH264 either.

Flags: needinfo?(geoff)
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9107384 - Flags: review?(jorgk)

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7c8575d4471b314d0287426c479a26b76d405137

Still waiting for Windows to do its thing, but I'm confident it'll be okay.

Comment on attachment 9107384 [details] [diff] [review]
1593544-remove-plugin-providers-1.diff

Thanks for digging into it.
Attachment #9107384 - Flags: review?(jorgk) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/integration/autoland/rev/1b6785df23d3
Stop loading plugin provider modules in Thunderbird. r=Gijs
Target Milestone: --- → Thunderbird 72.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a9f7c4aa047f
Stop loading plugin provider modules in Thunderbird. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.