TEST-UNEXPECTED-FAIL | comm/calendar/test/browser/browser_todayPane_visibility.js | A promise chain failed to handle a rejection: textbox is null - stack: @chrome://messenger/content/aboutAddonsExtra.js:63:23 and TEST-UNEXPECTED-FAIL | comm/mail/component
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file, 1 obsolete file)
1.15 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
First seen here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=8aa9c7cbd3f94bb90393e5c4a3b34a27bc147d14&selectedJob=274213057
Sorry, not many patches available this weekend, so we have one run on Friday night, plus Saturday's and Sunday's Daily on the same C-C changeset :-(
The failing line is
let textbox = document.getElementById("header-search");
let placeholder = textbox.getAttribute("placeholder");
and I don't see header-search in M-C any more. It was removed here:
https://hg.mozilla.org/mozilla-central/rev/32432781964994d55970b7499bb2a25c99e6f7b3#l14.94
in bug 1525175.
I guess we just need to replace it with search-addons:
https://hg.mozilla.org/mozilla-central/rev/32432781964994d55970b7499bb2a25c99e6f7b3#l23.74
Assignee | ||
Comment 1•5 years ago
|
||
Once you looked at your 15+ NI? you might want to look at this test failures.
This code does NOT work, but it works for me if I paste all the lines into the debug console twice. Go figure :-(
Assignee | ||
Comment 2•5 years ago
|
||
This fixes it.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e59f4d018a05
Port bug 1525175: Adapt to changed ID of add-ons search box. rs=bustage-fix
Assignee | ||
Comment 4•5 years ago
|
||
This should fix the tests since they were both failing on the line I fixed.
Comment on attachment 9106076 [details] [diff] [review] 1593546-addon-search-box.patch Review of attachment 9106076 [details] [diff] [review]: ----------------------------------------------------------------- Works for me, thanks.
Description
•