Closed Bug 1593546 Opened 5 years ago Closed 5 years ago

TEST-UNEXPECTED-FAIL | comm/calendar/test/browser/browser_todayPane_visibility.js | A promise chain failed to handle a rejection: textbox is null - stack: @chrome://messenger/content/aboutAddonsExtra.js:63:23 and TEST-UNEXPECTED-FAIL | comm/mail/component

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file, 1 obsolete file)

First seen here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=8aa9c7cbd3f94bb90393e5c4a3b34a27bc147d14&selectedJob=274213057

Sorry, not many patches available this weekend, so we have one run on Friday night, plus Saturday's and Sunday's Daily on the same C-C changeset :-(

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=518df4329a20f76b3bffd5f6201b007fde&tochange=8aa8ed80ea4325031cd613b5f85a3d6942

The failing line is

    let textbox = document.getElementById("header-search");
    let placeholder = textbox.getAttribute("placeholder");

and I don't see header-search in M-C any more. It was removed here:
https://hg.mozilla.org/mozilla-central/rev/32432781964994d55970b7499bb2a25c99e6f7b3#l14.94
in bug 1525175.

I guess we just need to replace it with search-addons:
https://hg.mozilla.org/mozilla-central/rev/32432781964994d55970b7499bb2a25c99e6f7b3#l23.74

Attached patch 1593546-addon-search-box.patch (obsolete) — Splinter Review

Once you looked at your 15+ NI? you might want to look at this test failures.

This code does NOT work, but it works for me if I paste all the lines into the debug console twice. Go figure :-(

Attachment #9106074 - Flags: review?(geoff)

This fixes it.

Assignee: nobody → jorgk
Attachment #9106074 - Attachment is obsolete: true
Attachment #9106074 - Flags: review?(geoff)
Attachment #9106076 - Flags: review?(acelists)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e59f4d018a05
Port bug 1525175: Adapt to changed ID of add-ons search box. rs=bustage-fix

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

This should fix the tests since they were both failing on the line I fixed.

Target Milestone: --- → Thunderbird 72.0
Comment on attachment 9106076 [details] [diff] [review]
1593546-addon-search-box.patch

Review of attachment 9106076 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks.
Attachment #9106076 - Flags: review?(acelists) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: