1593573 - When STP is disabled, the social category item is not correctly handled by the section logic

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: 743c07c7a9.png

Since we are only setting .hidden on the category item, the logic in reorderCategoryItem doesn't realize that it needs to pretend that the social category is basically always "None Detected".

Here's just one way to get into a state where the bug is visible:

1. Set urlclassifier.features.socialtracking.annotate.blacklistHosts to social-tracking-protection-digest256.dummytracker.org (currently necessary but this might be worked around on Steve's site at some point).
2. Open https://senglehardt.com/test/trackingprotection/test_pages/social_tracking_protection.html
3. Open about:config in a new tab and privacy.socialtracking.block_cookies.enabled to false.
4. Close the tab. The previous tab with Steve's site will be selected.
5. Now, open the protections panel.

Expected:
The "Allowed" section is completely hidden

Actual:
The "Allowed" section header is shown but with no items under it. (Screenshot attached.)

Gary, do you want to work on this? I think this should work:

1. Instead of setting .hidden on the category item, set a custom attribute (e.g. uidisabled or something)
2. Add a CSS rule to set display: none; on elements with this attribute.
3. Add || categoryItem.hasAttribute("uidisabled") to the condition here

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1593573 - Make sure we correctly build the UI when STP is disabled. r=xeonchen

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Never mind, I had some time to make a patch. :)

Comment 3

[Gary Chen [:xeonchen]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #2)

Never mind, I had some time to make a patch. :)

Thanks, please let me know if anything I can help :D

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1593573 - Update socialtracking UI test. r=xeonchen

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cf3d4786896f7c9973fc45dd0f1b5f6c7f912bb

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fa5d33ca68a
Make sure we correctly build the UI when STP is disabled. r=xeonchen
https://hg.mozilla.org/integration/autoland/rev/be848609eea8
Update socialtracking UI test. r=xeonchen

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1593573 - Use skipURLs prefs instead of whitelist testEntries in social tracking UI test. r=xeonchen

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaf25cd8fd03
Use skipURLs prefs instead of whitelist testEntries in social tracking UI test. r=xeonchen

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2fa5d33ca68a
https://hg.mozilla.org/mozilla-central/rev/be848609eea8
https://hg.mozilla.org/mozilla-central/rev/eaf25cd8fd03