1593654 - Can't expand CSS messages

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2019-11-04 at 14.28.51.png

In the latest Nightly [72.0a1 (2019-11-04) (64-bit)], the expandable arrows don't work anymore and throw an error in the browser toolbox (see attachement)

STR:

1. visit for example https://www.nytimes.com/ and open the console
2. look for any CSS warning and try to expand the message

ER: the message should expand
AR: nothing happens

Comment 1

[Martin Balfanz [:mbalfanz]]

Please note that the second warning ("options is undefined") appears when trying to toggle the same arrow a second time.

Comment 2

[Martin Balfanz [:mbalfanz]]

Here's the regression range I found: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0199ecf6c90bec82568f05006b998b5c2aa88281&tochange=15234f683370baca9a160c44b1cc280214b01045

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

The fix should be easy (default the option variable to empty object).
It wasn't caught by a test because we only have a mocha test for CSS warnings, so we never assert that we are retrieving the impacted elements; i'll add a mochitest for that.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1593654 - Fix issue when expanding CSS warnings. r=rcaliman.

The issue was in commands.js evaluateJSAsync function where
we were trying to use an undefined parameter.
The regression wasn't spooted earlier because we only have
mocha test for CSS warning, and they don't assert this
codepath.
A mochitest is added on this patch to ensure CSS Warnings
can be expanded, that they display the impacted elements
as expected, and that clicking on the icon selects the
expected element in the inspector.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd1d61b2ffa
Fix issue when expanding CSS warnings. r=rcaliman.

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9fd1d61b2ffa