1593714 - Copying with Ctrl+C doesn't always work

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dzmitry Malyshau [:kvark]]

I noticed that very often Ctrl+C doesn't manage to get the content copied. This appears to be a regression within the last week or two (gotta find a proper repro case and do a mozregression to be precise). I'm on Nightly 72.0a1 (2019-11-01) right now (interestingly, I had to copy-paste that twice because the first time it didn't work...).

Roughly speaking:

• I navigate a page, select something (doesn't matter if it's the address bar, or some piece of content), hit Ctrl+C
• I quickly switch to a different page, or app, try to paste it

Expected results:

• the copied content is pasted

Actual results:

• quite often, I see the old clip buffer content, not the new one. I think it gets worse if you switch off the place where the copy was done quickly. Could some messages fail to be delivered?

Comment 1

[Sebastian Simon]

I can reproduce this issue and I have posted some details about this on https://bugzilla.mozilla.org/show_bug.cgi?id=1593517#c1.

For the address bar I get a NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIClipboardHelper.copyString] at UrlbarInput.jsm:2231 every time, unless I blur the address bar and try again. Copying content only sometimes fails, but I never get an error message when it does (needs more trials to confirm this).

Comment 2

[Dzmitry Malyshau [:kvark]]

Thanks Sebastian!
I'm getting it almost constantly here on desktop. Worth noting that copying via a right-click menu is also affected.

Comment 3

[Dzmitry Malyshau [:kvark]]

Attachment: mozregression.log

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=311429021082163b091c36516107985c32736b15&tochange=f68c212c8b2a39cb6e26e17477a8d848e19cd6d3

Comment 4

[Dzmitry Malyshau [:kvark]]

Karl, would you want to take a look? Appears to be caused by bug 1590965, which I have no access to.

Comment 5

[Karl Tomlinson (:karlt)]

Thanks for reporting I'll request a back-out of those changes.

Comment 7

[Julien Cristau [:jcristau]]

Backed out:
https://hg.mozilla.org/mozilla-central/rev/063086c09dc6

Comment 8

[Karl Tomlinson (:karlt)]

I haven't managed to reproduce with plasma or marco.

Can people who can reproduce describe the desktop environment, please?
Is there an application running that keeps clipboard history?

Also, can someone attach the portion of a log recorded during a failure, please?
From, e.g. MOZ_LOG=WidgetClipboard:5 mozregression --launch 2019-11-02 --process-output stdout

It may be helpful to run watch -n 1 xsel -o -b in another terminal to identify when the copy fails.

Comment 9

[Dzmitry Malyshau [:kvark]]

Can people who can reproduce describe the desktop environment, please?

I have Solus/Budgie on Xorg.

Is there an application running that keeps clipboard history?

No, nothing like that is running, but we can find something if that helps.

I'll try to get some logs...

Comment 10

[Karl Tomlinson (:karlt)]

I have put up an alternative patch at https://hg.mozilla.org/try/rev/9999b381836382812a96c2685af4e6cc215441ea, which addresses a potential cause of trouble. Would you be able to test whether that works better for you, please?

Comment 11

[Dzmitry Malyshau [:kvark]]

Do you have a try push build (artifact) from that revision that I can test without building your patch?

Comment 12

[Karl Tomlinson (:karlt)]

I added some opt builds, which are now available from https://treeherder.mozilla.org/#/jobs?repo=try&revision=feaa18c34f9a23c50430a46baefe594b918754e1

Comment 13

[Dzmitry Malyshau [:kvark]]

Thanks Karl, and sorry about the delay! I confirm the try build does not have an issue on my machine. Fairly confident that it's good.

Comment 14

[Karl Tomlinson (:karlt)]

No need to apologize. Thank you very much for your help.