1593772 - Show text cursor for editable text pattern

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P5)

Description

[:Harald Kirschner :digitarald]

What were you doing?

1. Hover the pattern value in a Blocking entry

What happened?

Default cursor.

What should have happened?

Text cursor, similar to XHR Breakpoints.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This should be simple to fix.

1. The blocking label is using .request-blocking-label CSS
   https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/devtools/client/netmonitor/src/components/request-blocking/RequestBlockingPanel.js#116

2. There is already a CSS selector for it:
   https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/devtools/client/netmonitor/src/assets/styles/RequestBlockingPanel.css#29

So, the text cursor should be specified in it.

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

Here is the related part of the UI.

Honza

Comment 3

[kevinmkang97]

Hi, I'm a first time contributor and I'd like to claim this bug as a part of a class project. I can see from the above that the preliminary investigation was already in place, but where can I find build instructions to test and see it for myself?

Thanks!

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the help!

Here is docs for contributors/developers.
https://docs.firefox-dev.tools/

Honza

Comment 5

[kevinmkang97]

Okay, I've added text: cursor into the CSS selector, and it looks to be building and displaying the text cursor correctly. I also ran ./mach test all and nothing failed, so I think it's alright. Are there any other checks or tests I should be running?

Thanks,

Kevin

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Excellent!

The next step: please send the patch so, we can review it and land if it's ok:
https://docs.firefox-dev.tools/contributing/making-prs.html

Honza

Comment 7

[kevinmkang97]

Sounds good, can I just put you as a reviewer Honza?

Kevin

Comment 8

[Martin McNickle]

Attachment: Bug 1593772 - Show text cursor on the request blocking label to show it is editable. r=Honza

Comment 9

[Martin McNickle]

Attachment: dev-tools-request-block-label.png

Screenshot showing the text cursor on the label.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d091fe1fb2f
Show text cursor on the request blocking label to show it is editable. r=Honza

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5d091fe1fb2f