1593773 - Update main_summary view to use new location of FXA_CONFIGURED

Status: RESOLVED FIXED

(Data Platform and Tools :: General, task, P1)

Description

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Bug 1238810 (landed in 71+) removes the FXA_CONFIGURED histogram and replaces it with a value in the telemetry environment. The main_summary aggregation should handle either location.

The current Scala version does not: https://github.com/mozilla/telemetry-batch-view/blob/406ba9f45d7af72bebf0908d88439070a165ecf7/src/main/scala/com/mozilla/telemetry/views/MainSummaryView.scala#L698

ni mreid for visibility.

Comment 1

[Daniel Thorn [:relud]]

I will add this logic in SQL, we are moving from the scala version to the SQL version this week: https://github.com/mozilla/bigquery-etl/pull/258

Comment 2

[janet [:janet]]

:loines :relud - looks like the referenced changes in comment 1 were merged. Is there anything else that needs to be done here or is https://bugzilla.mozilla.org/show_bug.cgi?id=1582253 now unblocked?

Comment 3

[Daniel Thorn [:relud]]

this is unblocked, i'll file a PR to coalesce the fields

Comment 4

[Daniel Thorn [:relud]]

just to confirm, the new locations are environment.services.account_enabled and environment.services.sync_enabled?

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/bigquery-etl/pull/540

Comment 6

[Daniel Thorn [:relud]]

also, will this require main summary to be backfilled? how far back?

Comment 7

[Leif Oines [:loines]]

just to confirm, the new locations are environment.services.account_enabled and environment.services.sync_enabled?

According to about:telemetry this is camelCase, accountEnabled and syncEnabled. I don't know if they are snakecased somewhere during ingestion, though

also, will this require main summary to be backfilled? how far back?

looks like bug 1238810 landed in nightly on 2019-10-25, so I'd say we want it backfilled that far.

Comment 8

[Daniel Thorn [:relud]]

(In reply to Leif Oines [:loines] from comment #7)

According to about:telemetry this is camelCase, accountEnabled and syncEnabled. I don't know if they are snakecased somewhere during ingestion, though

we convert to snake_case when loading to bigquery

looks like bug 1238810 landed in nightly on 2019-10-25, so I'd say we want it backfilled that far.

sounds good, I'm also adding a scalar to main summary for bug 1582834, so i'll add that and we can backfill both at the same time.

Comment 9

[Daniel Thorn [:relud]]

I'm also adding a scalar to main summary for bug 1582834

nevermind, that one doesn't need a change to main summary.

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/bigquery-etl/pull/543

Comment 11

[Daniel Thorn [:relud]]

I checked the table and this is the only field that's present in the schema but missing from the query.

sorry, wrong bug

Comment 12

[Martin McNickle]

Attachment: Bug 1593773 - Show text cursor on the request blocking label to show it is editable. r=Honza