1593806 - The subdialog for selecting a "helper application" for an extension does not tell you what extension is being changed

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Robin Steuber (they/them) [:bytesized]]

Attachment: application extension bug.PNG

Steps to Reproduce:

1. Navigate to about:preferences
2. Search for "application"
3. In the "Applications" section, select an entry with a Content Type like "<extension> File" (i.e. pick something like "PNG File", not "Portable Document Format (PDF)").
4. Click the Action field and click "Use other..."
5. Observe the description of the file type

Expected result:
Description will display the content type selected (i.e. "PNG file").

Actual result
Description reads "{$extension} file" (see attached image).

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Unshipped UI regression that we should fix before release

Zibi, can you take a look? I imagine we're not passing along some of the necessary info to the helper app dialog for use with the labels in there.

Comment 2

[:Gijs (he/him)]

I think I have a fix.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1593806 - fix file type descriptions in appPicker.js and as a driveby, stop displaying a literal 'undefined' when using it for protocols, r?mkaply

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e84eb54d5651
fix file type descriptions in appPicker.js and as a driveby, stop displaying a literal 'undefined' when using it for protocols, r=mkaply

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e84eb54d5651

Comment 6

[:Gijs (he/him)]

Comment on attachment 9107225 [details]
Bug 1593806 - fix file type descriptions in appPicker.js and as a driveby, stop displaying a literal 'undefined' when using it for protocols, r?mkaply

Beta/Release Uplift Approval Request

• User impact if declined: Broken dialog text when picking applications to handle files in the preferences
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple, small JS-only change to pass the requisite data to the localization API
• String changes made/needed: n/a

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9107225 [details]
Bug 1593806 - fix file type descriptions in appPicker.js and as a driveby, stop displaying a literal 'undefined' when using it for protocols, r?mkaply

P1 and small patch that doesn't look likely to cause regressions, uplift approved for 71 beta 9, thanks.

Comment 8

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 72.0a1 (BuildId:20191103213857).

This issue is verified fixed using Firefox 72.0a1 (BuildId:20191111100226) on Windows 10 64bit.

Pending beta fix.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5440a1c471e5

Comment 10

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 71.0b9 (BuildId:20191111170815) on Windows 10 64bit.