Closed Bug 1593828 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20077 - css-deprecated-flexbox: make visibility change force layout

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20077 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20077
Details from upstream follow.

Scott Violet <sky@chromium.org> wrote:

css-deprecated-flexbox: make visibility change force layout

This patch makes changing visibility call
SetNeedsLayoutAndPrefWidthsRecalc(). Without this line clamp is
not correctly recalculated when visibilty changes.

BUG=1015987
TEST=wpt/compat/webkit-box-clamp-visibility-change.html

Change-Id: Ib68b03a7942d6cd78b13e3d0bb11ba1a8742cb5d
Reviewed-on: https://chromium-review.googlesource.com/1898398
WPT-Export-Revision: dcde6ec2e80b333a05b0b274d9a7a9ad5da307cf

Component: web-platform-tests → Layout
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37b2ec3044e4
[wpt PR 20077] - css-deprecated-flexbox: remove visibility checks in LayoutDeprecatedFlexibleBox, a=testonly

https://hg.mozilla.org/mozilla-central/rev/37b2ec3044e4

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.