1593838 - textbox-search-icon in about:addons' search field is no longer mirrored on RTL

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Itiel]

Attachment: תמונה.png

See attached.

This rule is still there:
https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/toolkit/themes/windows/global/textbox.css#65
But it has no effect, same if I change it to have the :dir(rtl) selector.

Comment 1

[Itiel]

The same applies to bug 1526269 btw, which bug 1525175 also regressed.

Comment 2

[Mark Striemer [:mstriemer]]

The theme icons are going away in bug 1575905, looks like the fix for that was for the old about:addons, so I'd be surprised if that worked prior to bug 1525175.

The icon looks right on Mac in RTL, but I do see it differing from about:preferences on Windows. Unsure about Linux, but I'd imagine a Windows fix will fix it too if it's off.

Comment 3

[Itiel]

I think the bigger issue here is :dir(rtl) and -moz-locale-dir(rtl) not being respected.
Future changes to about:addons that will require to do specific adjustments for RTL won't actually work properly on RTL.

Comment 4

[Itiel]

Huh, when RTL is on, a -moz-locale-dir(ltr) selector works on about:addons.
This can somewhat explain bug 1593840?

Comment 5

[Itiel]

Interesting.
After following this STR:

1. New profile, set intl.uidirection to 1, restart
2. Open about:addons, see the icon incorrently unflipped (same it would be as in LTR)
3. In a new tab, set intl.uidirection to 0
4. Set it again to 1
5. Go back to the already open about:addons page
   ... the icon will now be correctly mirrored. Reload the page and it'll unflip.

Comment 6

[Mark Striemer [:mstriemer]]

Should these icons even be flipped in RTL? The RTL guidelines [1] say magnifying glass icons should be right-handed, but this one is left-handed. This seems odd, but then looking in the Windows UI the search box next to the start menu has an icon with the same directionality. Perhaps it's supposed to be facing "forwards" on Windows? Linux uses the same icon, which makes me wonder if it should be using the Mac one which seems to be similar to what I see everywhere except for the Windows search.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/RTL_guidelines#What_to_mirror

Comment 7

[Itiel]

Thank for asking.

(In reply to Mark Striemer [:mstriemer] from comment #6)

Should these icons even be flipped in RTL? The RTL guidelines [1] say magnifying glass icons should be right-handed, but this one is left-handed.

Disclaimer: Both ntim and I were the ones who actually wrote that MDN doc :-)

By "right-handed" this refers to physically holding an object in your right hand.
See also:
https://material.io/design/usability/bidirectionality.html#mirroring-elements

Perhaps it's supposed to be facing "forwards" on Windows?

Following the info in the link above, it seems that ALL of Firefox's usage of the search sign should be switched to something like [1] (because the majority of people are holding it their right hand, regardless of RTL), but that's a discussion for another bug...

[1] https://searchfox.org/mozilla-central/source/browser/themes/shared/icons/search-glass.svg