1593857 - Do not show Tracking Protection icon if it's completely disabled

Status: NEW

(Firefox :: Protections UI, enhancement, P3)

Description

[Yaron]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Select Custom Enhanced Tracking Protection.
Uncheck all the check-boxes.

Actual results:

The protection icon is displayed in the URL-bar and on clicking it you see "Protection is on for this site".

Expected results:

No icon at all.

Comment 1

[Raluca Popovici, Desktop QA]

Hi,
This is the intended behavior for Tracking Protection, see link: https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android but I guess this could be a enhacement. Can you please take a look at this issue. Is there a way where we could remove the Shield Icon if its completely disabled ?

Comment 2

[Erica Wright [:ewright]]

Hi, thanks for the report!
As stated above this is the intended behaviour for the shield icon. At the moment we aren't considering removing it for sites where nothing is being blocked.
However, this brings up an interesting issue with the string "Enhanced Tracking Protection is ON for this site", should the string be different if all protections have been turned off? Should it be different if protections are on but nothing is blocked on this site?
@bmikel, @epang?

Comment 3

[Betsy Mikel [:betsymi]]

I would advocate for leaving the string as-is to reinforce to users that it's on and working.

Comment 4

[Eric Pang [:epang] UX]

Attachment: Tracking Protection Global Off State

I agree with Betsy that we should leave the string as in for the scenario when no trackers are found and TP is on.

We have a scenario designed for when a user has turned all protections off in the custom. It may have been overlooked?

1. TP icon - crossed out
2. String changes to: Enhanced Tracking Protection is OFF for all sites
3. Mange Protection Settings Link appears
4. Why tooltip: These are not blocked because Tracking Protection is off.

See the screen attached. Nihanth, can you take a look?

Thanks!

Comment 5

[Betsy Mikel [:betsymi]]

Slight edit, why tooltip should read: These are not blocked because Enhanced Tracking Protection is off.

Comment 6

[Eric Pang [:epang] UX]

Attachment: ETP Off Globally

Thanks, Betsy, updated the image and spec.
Full spec can be found here: https://mozilla.invisionapp.com/share/GSUWUPVC72H#/360900829_Tracking_Protection_Panel

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

The "protections globally OFF" state is unimplemented due to lack of resourcing. I suspect we'll get to this in H1.