Closed
Bug 1593864
Opened 5 years ago
Closed 5 years ago
Update the matrix-js-sdk to 2.4.3
Categories
(Chat Core :: Matrix, task)
Chat Core
Matrix
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 72
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
46.51 KB,
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
Building on bug 1533872, this updates the matrix-js-sdk again to pick up a few annoying fixes in it:
- We no longer need to modify any of the matrix-js-sdk thanks to an upstreamed fix (https://github.com/matrix-org/matrix-js-sdk/pull/1052)
- We can reduce the number of files mapped in the script loader (https://github.com/matrix-org/matrix-js-sdk/pull/1056).
I also thought this would be a good opportunity to go through the update directions I had written to make sure they made sense. :) I clarified a bunch of things (and gave real commands to copy and paste).
Assignee | ||
Comment 1•5 years ago
|
||
I think most of this patch can be rubber-stamped, but the part that needs a "real" review is the changes to README.md and matrix-sdk.jsm.
Attachment #9106391 -
Flags: review?(paul)
Assignee | ||
Updated•5 years ago
|
Attachment #9106391 -
Attachment is patch: true
Assignee | ||
Comment 2•5 years ago
|
||
Sorry about that. I had failed to refresh the changes to matrix-sdk.jsm.
Attachment #9106391 -
Attachment is obsolete: true
Attachment #9106391 -
Flags: review?(paul)
Attachment #9106392 -
Flags: review?(paul)
Comment 3•5 years ago
•
|
||
Comment on attachment 9106392 [details] [diff] [review] Patch v2 Review of attachment 9106392 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. I did a cursory check and matrix support is still appropriately functional for its current state of development. :)
Attachment #9106392 -
Flags: review?(paul) → review+
Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/9cad8d5e022b
Upgrade the matrix-js-sdk to v2.4.3. r=pmorris
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Target Milestone: --- → Instantbird 72
You need to log in
before you can comment on or make changes to this bug.
Description
•