1593888 - Bootlegging in jsrtfuzzing.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[Jeff Walden [:Waldo]]

jsrtfuzzing.cpp uses four different symbols that are static in js.cpp, and any of this only works because jsrtfuzzing.cpp is unified with js.cpp.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1593888 - Fix bootlegging errors in jsrtfuzzing.cpp. r=decoder

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8648a5cd07f3
Fix bootlegging errors in jsrtfuzzing.cpp.  r=decoder

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8648a5cd07f3

Comment 4

[Jeff Walden [:Waldo]]

Previous patch wasn't quite enough to address this -- partly because I forgot to add the necessary #include "shell/jsshell.h", whoops. This patch adds that, but also it beefs up some of the existing code by removing namespace blocks so that precisely where symbols come from can be a little clearer.

(Note that names inside a function within a namespace, will try to find those names inside that namespace -- so the shell::sArgv doesn't have to be qualified because it appears inside a function in js::shell. But I think it's helpful to see some unnecessary qualification to indicate precisely where the name is coming from.)

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1593888 - Actually finish the job of making rtfuzzing not bootleg stuff. r=decoder

Comment 6

[Jeff Walden [:Waldo]]

FWIW this should be the last needed change, try-run of this patch (minus negligible tweaking) came up green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3da24adac28c40a8c709e8ec18569f84ffba2b45&selectedJob=275026855

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a256ac8701b
Actually finish the job of making rtfuzzing not bootleg stuff.  r=decoder

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a256ac8701b