Closed Bug 1593888 Opened 3 years ago Closed 3 years ago

Bootlegging in jsrtfuzzing.cpp

Categories

(Core :: JavaScript Engine: JIT, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(2 files)

jsrtfuzzing.cpp uses four different symbols that are static in js.cpp, and any of this only works because jsrtfuzzing.cpp is unified with js.cpp.

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/8648a5cd07f3
Fix bootlegging errors in jsrtfuzzing.cpp.  r=decoder
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → jwalden

Previous patch wasn't quite enough to address this -- partly because I forgot to add the necessary #include "shell/jsshell.h", whoops. This patch adds that, but also it beefs up some of the existing code by removing namespace blocks so that precisely where symbols come from can be a little clearer.

(Note that names inside a function within a namespace, will try to find those names inside that namespace -- so the shell::sArgv doesn't have to be qualified because it appears inside a function in js::shell. But I think it's helpful to see some unnecessary qualification to indicate precisely where the name is coming from.)

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

FWIW this should be the last needed change, try-run of this patch (minus negligible tweaking) came up green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3da24adac28c40a8c709e8ec18569f84ffba2b45&selectedJob=275026855

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/1a256ac8701b
Actually finish the job of making rtfuzzing not bootleg stuff.  r=decoder
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.