2.43 - 9.53% raptor-tp6-wikipedia-firefox-cold loadtime (linux64-shippable, linux64-shippable-qr, macosx1014-64-shippable, windows10-64-shippable-qr) regression on push af790c1efe5d6e0ee45fad4c02f247467f11db0e (Mon November 4 2019)
Categories
(Core :: DOM: Navigation, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox70 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | + | fixed |
People
(Reporter: Bebe, Assigned: emilio)
References
(Regression)
Details
(Keywords: perf, perf-alert, regression)
Attachments
(1 file)
Raptor has detected a Firefox performance regression from push:
As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
10% raptor-tp6-wikipedia-firefox-cold fcp macosx1014-64-shippable opt 1,771.96 -> 1,940.83
8% raptor-tp6-wikipedia-firefox-cold macosx1014-64-shippable opt 1,950.25 -> 2,114.38
7% raptor-tp6-wikipedia-firefox-cold loadtime macosx1014-64-shippable opt 2,209.62 -> 2,366.33
7% raptor-tp6-wikipedia-firefox-cold fcp linux64-shippable opt 1,455.50 -> 1,552.42
6% raptor-tp6-wikipedia-firefox-cold linux64-shippable opt 1,472.40 -> 1,567.97
6% raptor-tp6-wikipedia-firefox-cold loadtime linux64-shippable opt 1,549.17 -> 1,646.58
6% raptor-tp6-wikipedia-firefox-cold loadtime linux64-shippable opt 1,551.46 -> 1,648.83
4% raptor-tp6-wikipedia-firefox-cold fcp linux64-shippable-qr opt 1,665.08 -> 1,733.25
4% raptor-tp6-wikipedia-firefox-cold linux64-shippable-qr opt 1,597.00 -> 1,654.46
3% raptor-tp6-wikipedia-firefox-cold loadtime linux64-shippable-qr opt 1,665.21 -> 1,723.00
3% raptor-tp6-wikipedia-firefox-cold windows10-64-shippable-qr opt 1,429.71 -> 1,471.42
2% raptor-tp6-wikipedia-firefox-cold fcp windows10-64-shippable-qr opt 1,518.08 -> 1,555.00
Improvements:
18% raptor-tp6-instagram-firefox fcp macosx1014-64-shippable opt 294.92 -> 241.29
16% raptor-tp6-instagram-firefox macosx1014-64-shippable opt 423.00 -> 357.12
You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23717
On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.
To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/TestEngineering/Performance/Raptor
*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***
Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/TestEngineering/Performance/Talos/RegressionBugsHandling
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Bug 1593690 should fix this.
Assignee | ||
Comment 2•5 years ago
|
||
Out of curiosity, do you have a profile handy? It could be useful to confirm that it'll get fixed by bug 1593690.
Reporter | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
I don't see any profile there, what am I missing?
Reporter | ||
Comment 5•5 years ago
|
||
looks like there is a issue generating the profiles:
Bug 1594330 - Task-cluster jobs fail when generating raptor gecko-profile tasks
Assignee | ||
Comment 6•5 years ago
|
||
Should be fixed now that the dependency is fixed, mind confirming?
Reporter | ||
Comment 7•4 years ago
|
||
Looks like we can't generate gecko profiles for commits pre-ci-movement
Comment 8•4 years ago
|
||
The priority flag is not set for this bug.
:neha, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 9•4 years ago
|
||
[Tracking Requested - why for this release]:
https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&series=mozilla-central,2135108,1,10&timerange=2592000 shows that the regression is still there.
Should we back out bug 1591717?
Assignee | ||
Comment 10•4 years ago
|
||
It's behind a nightly-only pref (https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/modules/libpref/init/StaticPrefList.yaml#4780).
I plan to get back to :visited
work in the coming weeks but if you think it's worth toggling it off for now that's fine for me too.
Assignee | ||
Comment 11•4 years ago
|
||
I'll figure out how to make it fast, but meanwhile this should fix the
regression.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f824b15913f Turn layout.css.notify-of-unvisited off for now. r=smaug
Comment 13•4 years ago
|
||
bugherder |
Reporter | ||
Comment 14•4 years ago
|
||
== Change summary for alert #24168 (as of Thu, 28 Nov 2019 10:29:39 GMT) ==
Improvements:
11% raptor-tp6-wikipedia-firefox-cold fcp macosx1014-64-shippable opt 1,987.83 -> 1,767.08
11% raptor-tp6-wikipedia-firefox-cold fcp macosx1014-64-shippable opt 1,993.58 -> 1,776.33
10% raptor-tp6-wikipedia-firefox-cold macosx1014-64-shippable opt 2,174.02 -> 1,959.06
9% raptor-tp6-wikipedia-firefox-cold loadtime macosx1014-64-shippable opt 2,440.17 -> 2,224.92
5% raptor-tp6-wikipedia-firefox-cold fcp linux64-shippable opt 1,530.17 -> 1,449.67
5% raptor-tp6-wikipedia-firefox-cold linux64-shippable opt 1,547.56 -> 1,469.68
5% raptor-tp6-wikipedia-firefox-cold loadtime linux64-shippable opt 1,619.25 -> 1,542.25
4% raptor-tp6-wikipedia-firefox-cold fcp linux64-shippable-qr opt 1,708.58 -> 1,638.67
4% raptor-tp6-wikipedia-firefox-cold fcp windows7-32-shippable opt 1,423.58 -> 1,365.67
4% raptor-tp6-wikipedia-firefox-cold linux64-shippable-qr opt 1,635.81 -> 1,569.43
4% raptor-tp6-wikipedia-firefox-cold fcp windows10-64-shippable opt 1,381.17 -> 1,330.17
3% raptor-tp6-wikipedia-firefox-cold loadtime windows7-32-shippable opt 1,589.08 -> 1,534.17
3% raptor-tp6-wikipedia-firefox-cold windows10-64-shippable opt 1,418.32 -> 1,371.51
3% raptor-tp6-wikipedia-firefox-cold loadtime linux64-shippable-qr opt 1,695.67 -> 1,641.00
3% raptor-tp6-wikipedia-firefox-cold windows10-64-shippable-qr opt 1,456.85 -> 1,412.75
3% raptor-tp6-wikipedia-firefox-cold loadtime windows10-64-shippable opt 1,538.25 -> 1,491.92
3% raptor-tp6-wikipedia-firefox-cold fcp windows10-64-shippable-qr opt 1,544.17 -> 1,498.33
3% raptor-tp6-wikipedia-firefox-cold loadtime windows10-64-shippable-qr opt 1,553.83 -> 1,509.50
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24168
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Hi Emilio, is qa needed here? If so, could you provide us with some steps? Thanks!
Assignee | ||
Comment 16•4 years ago
|
||
No shouldn't be needed. It's a minor regression fix with no user-observable effect
Updated•4 years ago
|
Updated•2 years ago
|
Description
•