Closed
Bug 1594123
Opened 4 years ago
Closed 4 years ago
Fix lookup of toolbarbutton-icon in TabsList to not use getAnonymousElementByAttribute
Categories
(Firefox :: Tabbed Browser, task, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
Spinning this out of https://bugzilla.mozilla.org/show_bug.cgi?id=1591145#c15 to land separately.
This code https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/browser/modules/TabsList.jsm#282-292 doesn't work. document.getAnonymousElementByAttribute is dead code now, and even when it wasn't this would have returned null ever since <toolbarbutton> stopped using XBL.
Assignee | ||
Comment 1•4 years ago
|
||
document.getAnonymousElementByAttribute is dead code now, and even when it wasn't this would
have returned null ever since <toolbarbutton> stopped using XBL.
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7271753097f9 Fix lookup of toolbarbutton-icon in TabsList r=mconley
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•