Pipelining "WARNING" should be revised...

VERIFIED FIXED in mozilla1.0.1

Status

SeaMonkey
Preferences
P2
major
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: Darin Fisher, Assigned: Darin Fisher)

Tracking

Trunk
mozilla1.0.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2 RTM] [ETA 07/27])

Attachments

(1 attachment, 1 obsolete attachment)

1.10 KB, patch
Darin Fisher
: review+
Darin Fisher
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
The pipelining "WARNING" message really shouldn't include the phrase
"experimental feature" any longer.  Kevin suggested "advanced feature" instead,
and I think that makes good sense.

Here's his rewording (repeated here, originally from bugscape bug 17549):

 "WARNING: pipelining is a feature designed to improve page-load performance but
  is not fully supported by some web servers and proxies. This feature is for
  advanced users only."
(Assignee)

Comment 1

16 years ago
Created attachment 92775 [details] [diff] [review]
v1 patch
(Assignee)

Updated

16 years ago
Severity: normal → major
Status: NEW → ASSIGNED
Keywords: mozilla1.0.1, nsbeta1
Priority: -- → P2
Whiteboard: [adt2 RTM]
Target Milestone: --- → mozilla1.0.1

Updated

16 years ago
Keywords: nsbeta1 → adt1.0.1, nsbeta1+

Comment 2

16 years ago
Comment on attachment 92775 [details] [diff] [review]
v1 patch

sr=rpotts@netscape.com
Attachment #92775 - Flags: superreview+

Comment 3

16 years ago
The use of "Warning" sounds dire, but I gather it's appropriate (as opposed to
"Note" or "Important") if the user perceives data loss. We normally reserve
"Warning" to matters of data loss or system corruption.

The wording it too lengthy. Suggested rewrite (note capitalization change, too): 

 "WARNING: Pipelining may improve page-load performance but
  is not fully supported by some web and proxy servers. This feature is for
  advanced users only."

Comment 4

16 years ago
Comment on attachment 92775 [details] [diff] [review]
v1 patch

r=gagan
Attachment #92775 - Flags: review+

Comment 5

16 years ago
what message are we going with here, the one Steve suggests, or somehting else?
pls advise ...
Blocks: 143047

Comment 6

16 years ago
I defer to Steve's expertise here.
(Assignee)

Comment 7

16 years ago
yeah, the new wording (in comment #3) sounds better to me as well.  new patch
forthcoming...
(Assignee)

Comment 8

16 years ago
Created attachment 92828 [details] [diff] [review]
v2 patch

reworded per Steve's suggestion.
Attachment #92775 - Attachment is obsolete: true

Updated

16 years ago
Keywords: approval
Whiteboard: [adt2 RTM] → [adt2 RTM] [ETA 07/27]
QA Contact: sairuh → benc

Comment 9

16 years ago
Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch.  Please get
drivers approval before checking in. When you check this into the branch, please
change the mozilla1.0.1+ keyword to fixed1.0.1

Keywords: adt1.0.1 → adt1.0.1+

Comment 10

16 years ago
Pipelining is an HTTP feature -> qa to Tom.

Should we just move the bug to HTTP as well?
QA Contact: benc → tever
(Assignee)

Comment 11

16 years ago
Comment on attachment 92828 [details] [diff] [review]
v2 patch

forwarding r=gagan, sr=rpotts
Attachment #92828 - Flags: superreview+
Attachment #92828 - Flags: review+

Updated

16 years ago
Keywords: mozilla1.0.1 → mozilla1.0.1+
(Assignee)

Comment 12

16 years ago
ok, fixed1.0.1
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Keywords: mozilla1.0.1+ → fixed1.0.1
Resolution: --- → FIXED

Comment 13

16 years ago
verified 8/13/02 builds - winNT4, linux rh6, mac osX

needs tested on trunk yet
Keywords: verified1.0.1

Updated

16 years ago
Keywords: fixed1.0.1

Comment 14

15 years ago
Shouldn't this be reopened as it was never fixed on the trunk?
no, because this shouldn't be on the trunk (pipelining works ...)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.