Enable DocumentChannel for ftp, file and blob.
Categories
(Core :: Networking, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(4 files)
Building on top of bug 1593560, adding support for ftp, file and blob.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
This mainly shows up when creating a DocumentChannel for a blob URI, and then we try switch to the 'real' blob channel and can't find an nsIChildChannel.
We could instead implement an IDPL parent/child class for this (like FileChannelChild/Parent), but the implementation of those is effectively the same (just call AsyncOpen from CompleteRedirectSetup), and I think is unnecessary boilterplate, since we can't have an actual redirect to a blob URI.
Depends on D51902
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D51903
|
|
Assignee | |
Comment 4•5 years ago
|
||
We fail this during test_invalid_mime_type_blob.html when using DocumentChannel for blobs without this.
DocumentChannelChild reports an internal redirect as it replaces itself with the real channel (BlobURLChannel), and we fail the CheckLoadURIWithPrincipal checks.
The old channel has a null principal (due to being a sandboxed iframe), and we compare that to the blob principal computed from the URI, which is a normal content principal.
Depends on D51904
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d1e8f14b42b Enable DocumentChannel for ftp, file and blob. r=nika https://hg.mozilla.org/integration/autoland/rev/0da839f538f2 Handle channel types that don't implement nsIChildChannel when switching to a real channel from DocumentChannel. r=mayhemer https://hg.mozilla.org/integration/autoland/rev/8b10deda7d0e Don't add a manual ref when constructing FileChannelChild, since it's a refcounted IPDL class. r=nika https://hg.mozilla.org/integration/autoland/rev/c07d058d206c Dont do nsContentSecurityManager checks for internal redirects. r=baku,ckerschb
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d1e8f14b42b
https://hg.mozilla.org/mozilla-central/rev/0da839f538f2
https://hg.mozilla.org/mozilla-central/rev/8b10deda7d0e
https://hg.mozilla.org/mozilla-central/rev/c07d058d206c
|
||
Comment 7•5 years ago
|
||
Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
Description
•