Closed
Bug 1594230
Opened 5 years ago
Closed 4 years ago
Use actorCreated callback to listen to 'pageshow' event in https://searchfox.org/mozilla-central/source/browser/actors/FormValidationChild.jsm
Categories
(Toolkit :: UI Widgets, enhancement, P5)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: ablayelyfondou, Assigned: gaurijove)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
In https://searchfox.org/mozilla-central/source/browser/actors/FormValidationChild.jsm, we need to listen to the "pageshow" event as soon as the actor is created. Currently, this is done in an improper way because JSWindowActor.actorCreated callback did not exist at the time of the port (in bug 1571080).
|
Reporter | |
Comment 2•4 years ago
|
||
Sure! I just set you as the assignee of this.
Assignee: nobody → gaurijove
Flags: needinfo?(ablayelyfondou)
|
Assignee | |
Comment 3•4 years ago
|
||
Can you please elaborate on what needs to be done?
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
|
Assignee | |
Comment 5•4 years ago
|
||
Hi Abdoulaye, can you please review the patch. I wasnt able to add your name as reviewer for the patch.
Flags: needinfo?(abdoulayes)
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(abdoulayes) → needinfo?(ablayelyfondou)
|
||
Updated•4 years ago
|
Attachment #9138292 -
Attachment description: Bug 1594230 - Use actorCreated callback to listen to 'pageshow' event. → Bug 1594230 - Use actorCreated callback to listen to 'pageshow' event. r=NeilDeakin
|
|
Reporter | |
Comment 6•4 years ago
|
||
Sorry for being late here. I've been pretty packed with school work lately but I am happy you're able to get what needed to be done without my help.
Now, I will remove myself from NI as this is almost fixed. Thanks!
Flags: needinfo?(ablayelyfondou)
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/123eb94bd14d Use actorCreated callback to listen to 'pageshow' event. r=NeilDeakin
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•