Closed Bug 1594265 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 20104 - Fix some tests for define() in CustomElementRegistry.html

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20104 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20104
Details from upstream follow.

Edgar Chen <echen@mozilla.com> wrote:

Fix some tests for define() in CustomElementRegistry.html

close #20091

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 45 subtests

Firefox

OK : 1
PASS : 31
FAIL : 13

Chrome

OK : 1
PASS : 44

Safari

OK : 1
PASS : 34
FAIL : 10

Firefox-only failures

/custom-elements/CustomElementRegistry.html
customElements.define must get callbacks of the constructor prototype: Firefox: FAIL
customElements.define must rethrow an exception thrown while converting a callback value to Function callback type: Firefox: FAIL
customElements.define must rethrow an exception thrown while getting callbacks on the constructor prototype: Firefox: FAIL

Other existing tests that now have a worse result

/custom-elements/CustomElementRegistry.html
customElements.define must get "prototype" property of the constructor: Firefox: PASS->MISSING, Chrome: FAIL->MISSING, Safari: PASS->MISSING
customElements.define must not throw when defining another custom element in a different global object during Get(constructor, "prototype"): Firefox: PASS->FAIL, Chrome: FAIL->PASS, Safari: PASS->FAIL

Other new tests that's don't pass

/custom-elements/CustomElementRegistry.html
customElements.define must get "prototype", "disabledFeatures", and "formAssociated" property of the constructor: Firefox: FAIL, Chrome: PASS, Safari: FAIL

See Also: → 1556334
See Also: → 1552313
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec1d0595fca4
[wpt PR 20104] - Fix some tests for define() in CustomElementRegistry.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0a24919537be
[wpt PR 20104] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.