1594283 - Fix usage of nsIDocShellTreeItem in nsDocShell::GetSameTypeParentIgnoreBrowserBoundaries

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/docshell/base/nsDocShell.cpp#2812

Assumes parent is in-process. Needs to be renamed "GetSameTypeInProcessParentIgnoreBrowserBoundaries", and callers changed to reflect naming.

Then audited for uses and checked to ensure that either this is only called on docshells with in-process parents, or that a null return value in the out-of-process parent case is handled.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

We can remove these methods since nsGlobalWindowOuter::GetInProcessParent() is only user for GetSameTypeParentIgnoreBrowserBoundaries().

• https://searchfox.org/mozilla-central/search?q=GetSameTypeParentIgnoreBrowserBoundaries&path=
• https://searchfox.org/mozilla-central/search?q=GetSameTypeRootTreeItemIgnoreBrowserBoundaries&path=

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1594283 - part 1: Remove nsIDocShell::GetSameTypeRootTreeItemIgnoreBrowserBoundaries().

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1594283 - part 2: Remove nsIDocShell::getSameTypeParentIgnoreBrowserBoundaries().

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Tetsuharu OHZEKI [:tetsuharu] (UTC+9) from comment #2)

We can remove these methods since nsGlobalWindowOuter::GetSameTypeRootTreeItemIgnoreBrowserBoundaries() is only user for GetSameTypeParentIgnoreBrowserBoundaries().

• https://searchfox.org/mozilla-central/search?q=GetSameTypeParentIgnoreBrowserBoundaries&path=
• https://searchfox.org/mozilla-central/search?q=GetSameTypeRootTreeItemIgnoreBrowserBoundaries&path=

For GetSameTypeParentIgnoreBrowserBoundaries(), I jumped to conclusions.
nsIDocShellTreeItem.itemType has multiple implementations nsWebBrowser::ItemType and nsDocShell::ItemType, so it might not only be chrome or content. We may get ride of GetSameTypeParentIgnoreBrowserBoundaries(), but I seem it requires more careful works to check whether actual nsIDocShellTreeItem is nsWebBrowser or nsDocShell if we remove it before we get ride of all of comparing to nsIDocShellTreeItem::typeChrome or nsIDocShellTreeItem::typeContent.

So I think it's better to rename GetSameTypeParentIgnoreBrowserBoundaries() to GetSameTypeInProcessParentIgnoreBrowserBoundaries or other names conservatively.

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1594283 - part 2: Rename nsIDocShell::GetSameTypeParentIgnoreBrowserBoundaries to nsIDocShell::GetSameTypeInProcessParentIgnoreBrowserBoundaries.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fa92481a0ad
part 1: Remove nsIDocShell::GetSameTypeRootTreeItemIgnoreBrowserBoundaries(). r=kmag
https://hg.mozilla.org/integration/autoland/rev/34d7fcc41ba9
part 2: Rename nsIDocShell::GetSameTypeParentIgnoreBrowserBoundaries to nsIDocShell::GetSameTypeInProcessParentIgnoreBrowserBoundaries. r=kmag

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0fa92481a0ad
https://hg.mozilla.org/mozilla-central/rev/34d7fcc41ba9