1594289 - Fix usage of nsIDocShellTreeItem in nsDocShell::CaptureState

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/docshell/base/nsDocShell.cpp#7124

This should be changed to using BrowsingContext to find child documents.

Users need to be fixed to handle the semantics that out of process children will not be touched, but that is part of ongoing session-history work.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Chris Peterson [:cpeterson]]

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Comment 3

[Neha Kochar [:neha]]

BFCache

Comment 4

[Neha Kochar [:neha]]

WONTFIX because this method won't be used with the new BFCache design that'd work with Fission and SessionHistoryInParent.