1594335 - calMonthGridPrinter.html and calWeekPrinter.html should use <html:template> and css for align/valign

Status: RESOLVED WORKSFORME

(Calendar :: Printing, task)

Description

[Magnus Melin [:mkmelin]]

Came across this in bug 1594331... calMonthGridPrinter.html and calWeekPrinter.html should use <html:template> and css for align/valign - which would be the right way to do it and also avoid needles hits on replacing deprecated attributes (they are actually deprecated in html too).

https://searchfox.org/comm-central/search?q=calMonthGridPrinter.html&path=

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template

Comment 1

[Mahak]

Hi Sir,
I'm new to open source and starting my first contribution but I'm little confused so could you please tell me from where should I start to learn and contribute to this project

Comment 2

[Magnus Melin [:mkmelin]]

Hi Mahak - https://searchfox.org/comm-central/source/calendar/import-export/calMonthGridPrinter.html currently has elements that are used as templates, and then cloned (https://searchfox.org/comm-central/rev/bc17d0ef9860233e9ef72dc9324221ba86d662ae/calendar/import-export/calMonthGridPrinter.js#158). But they are not templates... We should use <html:template> instead, per the link in comment 0.

The other thing to update, is to convert the align/valign attributes of the table to use the corresponding css instead. That is, text-align and vertical-align.

Comment 3

[ma18btech11011]

Hi,

Has this issue been resolved? I would like to work on it...

Comment 4

[Magnus Melin [:mkmelin]]

Still open, no progress afaik. Feel free to work on it.

Comment 5

[Barbara]

Hi,

I would like to work on this issue as well. From what I read, this is not a bug per say but something in the HTML that needs to be updated?

Thanks!

Comment 6

[Magnus Melin [:mkmelin]]

Correct, it's a code improvement.

Comment 7

[Magnus Melin [:mkmelin]]

Bug 1713045 took care of this.