Closed Bug 1594351 Opened 4 months ago Closed 3 months ago

Include remote agent status in about:support

Categories

(Remote Protocol :: Agent, enhancement, P1)

enhancement

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [puppeteer-alpha])

Attachments

(3 files)

One suggestion from dveditz that came out of the security review
is to include a flag in about:support to indicate when the remote
agent is listening (is active).

Blocks: 1542229
Priority: -- → P2
Whiteboard: [puppeteer-alpha]

Why don't we show the robot icon and orange-striped locationbar as what we do with Marionette? Was there a disagreement for that?

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #1)

Why don't we show the robot icon and orange-striped locationbar as
what we do with Marionette? Was there a disagreement for that?

That is tracked in bug 1526364.

Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: P2 → P1

This also needs to wait for bug 1543115 because it makes some changes to the nsIRemoteAgent interface.

Depends on: 1543115
Blocks: 1595073

Actually we can land it with the plain URL (without the main target’s WebSocket) first.
I’ll follow up on exposing the main target’s URL with bug 1595073 after this is fixed.

No longer blocks: 1595073
No longer depends on: 1543115
Blocks: 1595073

The remote agent is a forthcoming new low-level debugging interface in
Gecko. This constant will tell toolkit code that the feature is enabled.

The remote.enabled preference informs the user whether the remote
agent is enabled, i.e. "available to use", in the current Gecko runtime.

This adds a new remote agent section at the bottom of about:support.
This section displays useful troubleshooting information regarding
the remote agent.

The remote agent is a forthcoming low-level debugging interface
to Gecko. Because it exposes browser-internals to the surrounding
system we need a clear way for the user to find if it is listening
for browser-external connections.

The table, entitled "Remote Agent", contains the following new
information:

Listening	whether the HTTPD is listening for incoming connections
URL		connection endpoint for clients
No longer blocks: 1542229
Attachment #9107511 - Attachment description: bug 1594351: toolkit: include remote agent section in about:support; → bug 1594351: toolkit: include remote protocol section in about:support;
Blocks: 1595727
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b2ea992707b
toolkit: add AppConstants.REMOTE_AGENT; r=remote-protocol-reviewers,maja_zf,mconley
https://hg.mozilla.org/integration/autoland/rev/83567a7a5873
toolkit: whitelist remote.enabled pref for troubleshooting; r=remote-protocol-reviewers,maja_zf,Gijs
https://hg.mozilla.org/integration/autoland/rev/a19a226a8c6a
toolkit: include remote protocol section in about:support; r=remote-protocol-reviewers,fluent-reviewers,Gijs,flod,maja_zf
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Regressions: 1597036
No longer regressions: 1597036
You need to log in before you can comment on or make changes to this bug.