1594408 - The “Try Send Tab” label wrongly exceeds the boundaries of the button on Russian locale

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andreea Cupsa [:acupsa], Experiments QA]

Attachment: image_2019_11_06T13_20_35_638Z.png

[Affected versions]:

• Firefox Beta 71.0b7 Ru locale, Build ID: 20191104135555
• Firefox Nightly 72.0a1 Ru locale, Build ID: 20191106095742

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• You are logged into Firefox Sync.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Navigate to the https://time.com/ website and click on one of the articles from the website.
3. Click on the “Recommendation” icon from the address bar.
4. Observe the “Try Send Tab” button.

[Expected result]:

• The button is correctly displayed and the string does not exceed the boundaries of the button.

[Actual result]:

• The “Try Send Tab” label exceeds the boundaries of the button.

[Notes]:

• This issue is only reproducible on the "SEND_RECIPE_TAB_CFR" and "SEND_TAB_CFR", and is not reproducible on the "PDF_URL_FFX_SEND" .
• Attached a screenshot of the issue.

Comment 1

[Tim Spurway [:tspurway]]

:aaron, should this show an ellipsis in this case?

Comment 2

[Francesco Lodolo [:flod]]

I don't think we should use ellipsis, there should be plenty of space for show the entire text. Worse case scenario, it should wrap on two lines.

Ellipsis are just bad for localization, there are languages where the sense of the entire sentence depends on the last word.

Comment 3

[Aaron Benson]

I agree with and defer to :flod here for localization considerations. Can we make the panel wider or have the text wrap?

Comment 4

[Andrei Oprea [:andreio]]

Attachment: image_2019_11_20T11_53_23_263Z.png

Translation was updated and the text no longer overflows.

Comment 5

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue and is no longer reproducible on Firefox Beta 71.0b11 (Build ID: 20191118154140) and Firefox Nightly 72.0a1 (Build ID: 20191119215132) on Windows 10 x64, Mac 10.14.6 and Arch Linux.