1594416 - Compare view permalinks take too much time to scroll onto

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

STR

1. Go to a random Compare view (e.g)
2. Click on any of the # permalinks from the left side of any table.

Expected results:
The page automatically scrolls onto the row which contained the #.

What we actually get:
It takes about 3 seconds for the scroll to happen. Even worse, the row is hidden behind the new navbar.

Both these issues need to be addressed, as the feature added back bug 1202731 is almost useless now.

Comment 1

[Sarah Clements [:sclements]]

I've tested this recently and I'm not seeing the 3 second lag when clicking on a permalink. Are you still experiencing this Ionut?

The scroll issue is a bit trickier because of how the top level container is composed with react router vs ui router (used with angular). Looking into a few solutions.

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Sarah Clements [:sclements] from comment #1)

I've tested this recently and I'm not seeing the 3 second lag when clicking on a permalink. Are you still experiencing this Ionut?

Yes, I'm still experiencing this issue.

Comment 3

[Sarah Clements [:sclements]]

I have a solution to both issues - I'll get a patch submitted tomorrow.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5728

Comment 5

[Sarah Clements [:sclements]]

Merged: https://github.com/mozilla/treeherder/commit/fc1e660053b4c636d0820ec44b9475518263db76