Closed Bug 1594432 Opened 7 months ago Closed 2 months ago

Remove `aContext` from `nsIChildChannel.completeRedirectSetup`

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mayhemer, Assigned: sonakshisaxena1)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

We removed that recently from AsyncOpen, here it doesn't make sense any longer too.

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/netwerk/base/nsIChildChannel.idl#34

Priority: -- → P2
Whiteboard: [necko-triaged]

(In reply to Honza Bambas (:mayhemer) from comment #0)

We removed that recently from AsyncOpen, here it doesn't make sense any longer too.

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/netwerk/base/nsIChildChannel.idl#34

Hey Honza
Can I work on this?
Thanks :)

Yes! Thanks!

Assignee: nobody → sonakshisaxena1
Status: NEW → ASSIGNED

(In reply to Honza Bambas (:mayhemer) from comment #2)

Yes! Thanks!

I have submitted the patch for this https://phabricator.services.mozilla.com/D68177 but it says that

This is a secure revision.
Please use the CC list of the associated bug in Bugzilla to manage access and subscribership of this revision. Changes made here may be overwritten.
Please do not land this revision using `arc land` to prevent data leakage.

I am not sure how to submit, as the revision is only saved as a draft.

Ah, it got submitted now :)
Please review.
Thanks :)

Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0cd0ef64e426
Remove aContext from nsIChildChannel.completeRedirectSetup r=valentin
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.