Closed Bug 1594457 Opened 5 months ago Closed 5 months ago

DOMTitleChanged event handling should check that event came from the current document

Categories

(Firefox :: Tabbed Browser, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

(In reply to :Gijs (he/him) from bug 1588142 comment #13)

(In reply to Brian Grinstead [:bgrins] from bug 1588142 comment #12)

[I can easily see about:preferences in the tab title] by holding ctrl+r with the tab opened).

This seems unrelated. It's caused by re-entrancy, basically. DOM fires DOMTitleChanged events asynchronously, and so we manage to process a previous document's event when we've already started loading a different document in the same docshell, which is how we end up in setTabTitle (from https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/browser/base/content/tabbrowser.js#5239-5258 ) without a title. Adding:

        if (event.target != browser.docShell.document) {
          return;
        }

Fixes this. I no longer see about:preferences show up when holding down accel+r. I will put this patch up separately as it seems the right thing anyway.

Priority: -- → P3
See Also: → 1588142
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a2af5be34b6b
fix DOMTitleChanged handling for reloads, r=bgrins
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Regressions: 1595924, 1595925, 1596272
Regressions: 1596672
Regressions: 1595888
Regressions: 1595945
Regressions: 1595946
Regressions: 1595949
Regressions: 1596008
Regressions: 1596010
Regressions: 1596062
Regressions: 1596261
You need to log in before you can comment on or make changes to this bug.