1594457 - DOMTitleChanged event handling should check that event came from the current document

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from bug 1588142 comment #13)

(In reply to Brian Grinstead [:bgrins] from bug 1588142 comment #12)

[I can easily see about:preferences in the tab title] by holding ctrl+r with the tab opened).

This seems unrelated. It's caused by re-entrancy, basically. DOM fires DOMTitleChanged events asynchronously, and so we manage to process a previous document's event when we've already started loading a different document in the same docshell, which is how we end up in setTabTitle (from https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/browser/base/content/tabbrowser.js#5239-5258 ) without a title. Adding:

        if (event.target != browser.docShell.document) {
          return;
        }

Fixes this. I no longer see about:preferences show up when holding down accel+r. I will put this patch up separately as it seems the right thing anyway.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1594457 - fix DOMTitleChanged handling for reloads, r?bgrins

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2af5be34b6b
fix DOMTitleChanged handling for reloads, r=bgrins

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a2af5be34b6b