Closed Bug 1594487 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 20129 - Ensure forward progress in SVGSMILElement::ResolveInterval

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20129 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20129
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Ensure forward progress in SVGSMILElement::ResolveInterval

With some unlucky combinations of parameters (timing and current time),
we could end up spinning in the resolve loop, (re)resolving the same
interval over and over, not making forward progress.
Guard against this by bumping the next "begin after" value by epsilon if
the resolved end is the same as the current "begin after".

Bug: 1021630
Change-Id: I71ba25cd423c24428f5d3f41f05fc83a2a1693cb
Reviewed-on: https://chromium-review.googlesource.com/1901043
WPT-Export-Revision: f0abfe8cde9dd0055a27d9a4983842856f7a856f

Component: web-platform-tests → SVG
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 1 subtests

Firefox

OK : 1
FAIL: 1

Chrome

TIMEOUT: 1

Safari

OK : 1
PASS: 1

New tests that's don't pass

/svg/animations/short-simple-duration-and-fractional-repeatcount.html
Short simple duration and fractional repeatCount does not hang: Firefox: FAIL, Chrome: MISSING, Safari: PASS

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0e9fed9a5b0
[wpt PR 20129] - Ensure forward progress in SVGSMILElement::ResolveInterval, a=testonly
https://hg.mozilla.org/integration/autoland/rev/cd81374a716f
[wpt PR 20129] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.