Closed Bug 1594499 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20132 - Fixed crash issue when list inside a contain element

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20132 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20132
Details from upstream follow.

Cathie Chen <cathiechen@igalia.com> wrote:

Fixed crash issue when list inside a contain element

ListItem will check the layout tree position of marker if the subtree
of li is changed which sets lifecycle state to kInLayoutSubtreeChange.
Marker might be reattached which will cause relayout. If it's inside
a contain element, it will trigger ScheduleRelayoutOfSubtree which
requires lifecycle state \<= kStyleClean. So there's a DCHECK failure.
To fix this, make sure don't change marker layout tree position unless
li is NormalChildNeedsLayout which can stop marker triggering
ScheduleRelayoutOfSubtree. And adding restriction to reattach marker.

Bug: 1004764
Change-Id: Id7c8aedafb2deed21d48f726d54a51f4f346e7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901011
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713066}

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

ERROR: 1

Chrome

ERROR: 1

Safari

ERROR: 1

New tests that's don't pass

/css/css-lists/list-inside-contain.html: Firefox: ERROR, Chrome: ERROR, Safari: ERROR

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/453926405b15
[wpt PR 20132] - Fixed crash issue when list inside a contain element, a=testonly

https://hg.mozilla.org/mozilla-central/rev/453926405b15

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.