1594516 - Use baseScript() in lieu of nonLazyScript() where possible

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1594516 - Use baseScript() instead of nonLazyScript() for needsHomeObject r?tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1594516 - Use baseScript() for accessing funHasExtensibleScope r?tcampbell

Depends on D52071

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1594516 - Use baseScript() for argumentsHasVarBinding() r?tcampbell

Depends on D52072

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

(Marking as leave-open just to give myself a little time to look for some more)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473da6de8cd2
Use baseScript() instead of nonLazyScript() for needsHomeObject r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ce0622a48edc
Use baseScript() for accessing funHasExtensibleScope r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/57e32412ad90
Use baseScript() for argumentsHasVarBinding() r=tcampbell

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/473da6de8cd2
https://hg.mozilla.org/mozilla-central/rev/ce0622a48edc
https://hg.mozilla.org/mozilla-central/rev/57e32412ad90

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1594516 - Use baseScript() for setIsDefaultClassConstructor r?tcampbell

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1594516 - Use baseScript() for hasMappedArgsObject, and remove unused setter r?tcampbell

This flag is actually set inside of initFromFunctionBox, and doesn't need a setter

Depends on D52222

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1594516 - Use baseScript to access isDerivedClassConstructor r?tcampbell

Depends on D52223

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee5b5cbfc6dd
Use baseScript() for setIsDefaultClassConstructor r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/cb1d6ff78a03
Use baseScript() for hasMappedArgsObject, and remove unused setter r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/15b3172e3743
Use baseScript to access isDerivedClassConstructor r=tcampbell

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee5b5cbfc6dd
https://hg.mozilla.org/mozilla-central/rev/cb1d6ff78a03
https://hg.mozilla.org/mozilla-central/rev/15b3172e3743

Comment 12

[Matthew Gaudet (he/him) [:mgaudet]]

Gonna close this one for now; Others if found can go under a new bug.